Page MenuHomePhabricator
Create Task
Maniphest T64761

VisualEditor: The style of error message for invalid page title for link should be more apparent in style
Closed, ResolvedPublic
Actions

Description

Screenshot

Steps to reproduce:

1.Open a page with VE
2.Open the link inspector
3.Now enter something invalid for link inspector , for example: File:Joo Chiat Place.jpg|Item 1

Observed Result:

An error message appears for invalid page title , the style of the error message should be much more apparent like red

See the screenshot attached

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65
OS: MAC OS X 10. 8. 5

Version: unspecified
Severity: minor

Attached:

Screen_Shot_2014-03-17_at_4.04.27_PM.png (539×948 px, 50 KB)

Details

Reference
bz62761

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 2:58 AM
• bzimport added projects: VE-deploy-2014-08-14, VisualEditor-EditingTools, Design, good first task.
• bzimport set Reference to bz62761.
Ryasmeen created this task.Mar 17 2014, 11:09 PM
gerritbot added a comment.Jul 29 2014, 7:12 PM

Change 150297 had a related patch set uploaded by Palerdot:
Fixed Bug 62761, added invalid link title style.

https://gerrit.wikimedia.org/r/150297

palerdot added a comment.Jul 29 2014, 7:17 PM

I have made a fix to this bug. The gerrit patchset link is https://gerrit.wikimedia.org/r/#/c/150297/

Things done:
A new CSS File
've.ui.MWLinkTargetInputWidget.css' is added to the path 'VisualEditor/modules/ve-mw/ui/styles/widgets'. Warning text style is added to the class '.ve-ui-mwLinkTargetInputWidget-warning' in this file. The CSS File is included in the style resources in the file 'VisualEditor.php'. Tested in latest stable firefox, chrome in Ubuntu 14.04.

Please review the changes. I'm new to open source contribution, So let me know if I have done the fix to the bug in the right way. Thanks.

palerdot added a comment.Jul 29 2014, 7:19 PM

Screenshot of Fix for Bug 62761

This is the screenshot of the fix I have made for the bug 62761. The gerrit patch link is https://gerrit.wikimedia.org/r/#/c/150297/

Attached:

Fixed_VE_Bug_62761.png (768×1 px, 122 KB)

palerdot added a comment.Jul 29 2014, 7:22 PM

Comment on attachment 16097
Screenshot of Fix for Bug 62761

The color in the screenshot is red. I have changed the color to #d45353 to match the other warning elements in the mediawiki page.

gerritbot added a comment.Jul 31 2014, 6:37 PM

Change 150297 had a related patch set uploaded by Palerdot:
Fixed Bug 62761, added invalid link title style.

https://gerrit.wikimedia.org/r/150297

gerritbot added a comment.Jul 31 2014, 6:52 PM

Change 150297 merged by jenkins-bot:
MWLinkTargetInputWidget: Add styles for invalid link titles

https://gerrit.wikimedia.org/r/150297

Aklapper added a comment.Nov 15 2014, 12:13 PM

All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Ryasmeen added a comment.Nov 17 2014, 11:29 PM

Nice!

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 1:48 AM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL