Page MenuHomePhabricator

VisualEditor: [Regression wmf21] 'Switch to source editing' does nothing, causes js error
Closed, ResolvedPublic

Description

Reported by users and repro'd in beta labs

Log in and edit any page with VE at http://en.wikipedia.beta.wmflabs.org/

From the hamburger list select "Switch to source editing"

Nothing happens. In the javascript console find the error

Uncaught Error: OO.ui.Tool.onSelect not implemented in this subclass:function VeUiMWEditModeSourceTool(toolGroup,config){ve.ui.MWEditModeTool.call(this,toolGroup,config);}


Version: unspecified
Severity: normal

Details

Reference
bz63503

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz63503.

also repro'd on test2wiki

Change 123806 had a related patch set uploaded by Alex Monk:
Revert edit mode tool's onSelect method

https://gerrit.wikimedia.org/r/123806

Change 123806 had a related patch set uploaded by Alex Monk:
Revert edit mode tool's onSelect method

https://gerrit.wikimedia.org/r/123806

Change 123806 merged by jenkins-bot:
Revert edit mode tool's onSelect method

https://gerrit.wikimedia.org/r/123806

Change 123825 had a related patch set uploaded by Jforrester:
Revert edit mode tool's onSelect method

https://gerrit.wikimedia.org/r/123825

Change 123825 merged by jenkins-bot:
Revert edit mode tool's onSelect method

https://gerrit.wikimedia.org/r/123825

Verified the fix in mw.org