Page MenuHomePhabricator

Vector: Watch star should not remove focus outlint
Closed, ResolvedPublic

Description

When tabbing through the header on a regular page, each of the tabs reacts to focus using the browser default behaviour (on Mac this is often a blue outline).

When making it to the watch star, however, it's gone (there is a very subtle color change inside the star, but that's too subtle for focus, it's barely enough for hover).

There doesn't seem to be any reason for this (it's not explicitly removed from :focus, just from the element in general and :focus inherits it).

Fro the commit history, looks like this was added way back to deal with image outlines, but this has been refactored since and just forgotten.


Version: 1.18.x
Severity: normal

Details

Reference
bz64934

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:20 AM
bzimport set Reference to bz64934.
Krinkle created this task.May 6 2014, 12:38 AM

Change 131643 had a related patch set uploaded by Krinkle:
Vector: Don't supress focus outline on watch star

https://gerrit.wikimedia.org/r/131643

Recommending backport to 1.23.

Change 131643 merged by jenkins-bot:
Vector: Don't supress focus outline on watch star

https://gerrit.wikimedia.org/r/131643

Change 131667 had a related patch set uploaded by Bartosz Dziewoński:
Vector: Don't supress focus outline on watch star

https://gerrit.wikimedia.org/r/131667

Change 131667 merged by jenkins-bot:
Vector: Don't supress focus outline on watch star

https://gerrit.wikimedia.org/r/131667