Test various values, including:
0,1,many,
-1, -somethingelse,
None (should probably throw a warning given it's not actually an allowed value)
See https://gerrit.wikimedia.org/r/#/c/131991/ for more details.
Version: core-(2.0)
Severity: normal
Description
Description
Details
Details
- Reference
- bz65013
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Xqt | T58190 API design (tracking) | |||
| Resolved | Xqt | T66489 Clean up limit handling (data/api.py) | |||
| Invalid | None | T60941 Missing unit tests for pywikibot library (tracking) | |||
| Resolved | Xqt | T67013 Test QueryGenerator.limit |
Event Timeline
Comment Actions
Some additional hints
Look at Site.preloadpages() method at site.py line 1381
QueryGenerator.limit is set to -1:
rvgen.set_maximum_items(-1) # suppress use of "rvlimit" parameter
Documentation of QueryGenerator.set_maximum_items() Shows
"""
If set to -1 (or any negative value), the "limit" parameter will be omitted from the request. For some request types (such as prop=revisions), this is necessary to signal that only current revision is to be returned.
"""
Comment Actions
Change 132387 had a related patch set uploaded by Xqt:
(bug 65013) Test QueryGenerator.limit