Page MenuHomePhabricator

Test QueryGenerator.limit
Closed, ResolvedPublic


Test various values, including:

-1, -somethingelse,
None (should probably throw a warning given it's not actually an allowed value)

See for more details.

Version: core-(2.0)
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:25 AM
bzimport set Reference to bz65013.
bzimport added a subscriber: Unknown Object (????).
Xqt added a comment.May 7 2014, 7:12 PM

Some additional hints

Look at Site.preloadpages() method at line 1381
QueryGenerator.limit is set to -1:

rvgen.set_maximum_items(-1) # suppress use of "rvlimit" parameter

Documentation of QueryGenerator.set_maximum_items() Shows

If set to -1 (or any negative value), the "limit" parameter will be
omitted from the request. For some request types (such as
prop=revisions), this is necessary to signal that only current
revision is to be returned.


Change 132387 had a related patch set uploaded by Xqt:
(bug 65013) Test QueryGenerator.limit

Change 132387 merged by jenkins-bot:
(bug 65013) Test QueryGenerator.limit

Xqt claimed this task.Oct 1 2018, 7:39 PM