Page MenuHomePhabricator

Test QueryGenerator.limit
Closed, ResolvedPublic

Description

Test various values, including:

0,1,many,
-1, -somethingelse,
None (should probably throw a warning given it's not actually an allowed value)

See https://gerrit.wikimedia.org/r/#/c/131991/ for more details.


Version: core-(2.0)
Severity: normal

Details

Reference
bz65013

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:25 AM
bzimport added a project: Pywikibot-General.
bzimport set Reference to bz65013.
bzimport added a subscriber: Unknown Object (????).
Xqt added a comment.May 7 2014, 7:12 PM

Some additional hints

Look at Site.preloadpages() method at site.py line 1381
QueryGenerator.limit is set to -1:

rvgen.set_maximum_items(-1) # suppress use of "rvlimit" parameter

Documentation of QueryGenerator.set_maximum_items() Shows
"""

If set to -1 (or any negative value), the "limit" parameter will be
omitted from the request. For some request types (such as
prop=revisions), this is necessary to signal that only current
revision is to be returned.

"""

Change 132387 had a related patch set uploaded by Xqt:
(bug 65013) Test QueryGenerator.limit

https://gerrit.wikimedia.org/r/132387

Change 132387 merged by jenkins-bot:
(bug 65013) Test QueryGenerator.limit

https://gerrit.wikimedia.org/r/132387

Xqt claimed this task.Oct 1 2018, 7:39 PM