Page MenuHomePhabricator

JQMIGRATE: jQuery.fn.andSelf() replaced by jQuery.fn.addBack()
Closed, DeclinedPublic

Description

Triggered when clicking on "add links" for adding iw links to a new article (i.e. one without an exisiting Wikidata entry). Clicing the link triggers a pop-up and also the JQMIGRATE warning

"JQMIGRATE: jQuery.fn.andSelf() replaced by jQuery.fn.addBack()" load.php:10350
console.trace(): load.php:10352
migrateWarn() load.php:10352
jQuery.fn.andSelf() load.php:10640
visible() jquery.ui.core.js:204
focusable() jquery.ui.core.js:200
.tabbable() jquery.ui.core.js:229
elementMatcher/<() load.php:2160
matcherFromGroupMatchers/superMatcher() load.php:2375
Sizzle</Sizzle.select() load.php:2550
Sizzle() load.php:879
.find() load.php:2704
.open() jquery.ui.dialog.js:343
._init() jquery.ui.dialog.js:199
$.Widget.prototype._createWidget() jquery.ui.widget.js:168
$.widget/$[namespace][name]() jquery.ui.widget.js:63
$.widget.bridge/$.fn[name]/<() jquery.ui.widget.js:129
.each() load.php:383
jQuery.prototype.each() load.php:136
$.widget.bridge/$.fn[name]() jquery.ui.widget.js:124
._createDialog() jquery.wikibase.linkitem.js:176
._create/<() jquery.wikibase.linkitem.js:116
jQuery.Callbacks/fire() load.php:3119
jQuery.Callbacks/self.fireWith() load.php:3231
.Deferred/</deferred[tuple[0]]() load.php:3321
mw.Api.prototype.ajax/xhr<() mediawiki.api.js:222
jQuery.Callbacks/fire() load.php:3119
jQuery.Callbacks/self.fireWith() load.php:3231
done() load.php:9275
.send/callback() load.php:9685


Version: unspecified
Severity: minor

Details

Reference
bz66520

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:21 AM
bzimport set Reference to bz66520.
bzimport added a subscriber: Unknown Object (MLST).

Note that this function (i.e. link appearing) only seems to work consistently in Firefox (separate bugg for that) and that clicking the link additionally throws a "JQMIGRATE: jQuery.browser is deprecated" warning.

Example page: https://sv.wikipedia.org/w/index.php?title=Marta_von_Fieandt-Björkman&uselang=en

Which exact file is jQuery.fn.andSelf() loaded from? (attaching a debug=true parameter to the URL should provide more info in the browser error console)

Sadly the above trace is the same as that for debug=true in firefox.

Line 204 in jquery.ui.core.js seems to contain the following though

function visible( element ) {
return !$( element ).parents().andSelf().filter(function() {

		return $.curCSS( this, "visibility" ) === "hidden" ||
			$.expr.filters.hidden( this );

}).length;
}

Closing as WORKSFORME. See also bug 69350.