Page MenuHomePhabricator

{{#time}} parser function produces incorrect dates when displaying dates before 1941 in Thai language
Open, LowPublic

Description

According to https://en.wikipedia.org/wiki/Thai_solar_calendar#New_year {{#time:xkY|1940-01-01|th}} should return 2482 but returns 2483.


Version: unspecified
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:13 AM
bzimport set Reference to bz66648.
bzimport added a subscriber: Unknown Object (MLST).

Change 428129 had a related patch set uploaded (by Superyetkin; owner: Superyetkin):
[mediawiki/core@master] Bug: T68648

https://gerrit.wikimedia.org/r/428129

Change 428129 had a related patch set uploaded (by Krinkle; owner: Superyetkin):
[mediawiki/core@master] Fix the bug for dates before 1941 in Thai language

https://gerrit.wikimedia.org/r/428129

Change 428129 merged by jenkins-bot:
[mediawiki/core@master] Fix the bug for dates between 1912 and 1941 in Thai language

https://gerrit.wikimedia.org/r/428129

The functionality has arrived for wikis but the commit does not appear in the release notes. Is something wrong?

Jarekt claimed this task.

I just tried "{{#time:xkY|1940-01-01|th}}" on Commons and got "2482", so my guess is that this is fixed. Closing

Jarekt removed Jarekt as the assignee of this task.

My closing was premature: I tried

  • {{#time: xkY-m|1941-01}} / 1941-01
  • {{#time: xkY-m|1940-12}} / 1940-12
  • {{#time: xkY-m|1940-11}} / 1940-11
  • {{#time: xkY-m|1940-10}} / 1940-10
  • {{#time: xkY-m|1940-09}} / 1940-09
  • {{#time: xkY-m|1940-08}} / 1940-08
  • {{#time: xkY-m|1940-07}} / 1940-07
  • {{#time: xkY-m|1940-06}} / 1940-06
  • {{#time: xkY-m|1940-05}} / 1940-05
  • {{#time: xkY-m|1940-04}} / 1940-04
  • {{#time: xkY-m|1940-03}} / 1940-03
  • {{#time: xkY-m|1940-02}} / 1940-02
  • {{#time: xkY-m|1940-01}} / 1940-01
  • {{#time: xkY-m|1939-12}} / 1939-12
  • {{#time: xkY-m|1939-11}} / 1939-11

and got

2484-01 / 1941-01
2483-12 / 1940-12
2483-11 / 1940-11
2483-10 / 1940-10
2483-09 / 1940-09
2483-08 / 1940-08
2483-07 / 1940-07
2483-06 / 1940-06
2483-05 / 1940-05
2483-04 / 1940-04
2482-03 / 1940-03
2482-02 / 1940-02
2482-01 / 1940-01
2482-12 / 1939-12
2482-11 / 1939-11

which does not match months in the table at https://en.wikipedia.org/wiki/Thai_solar_calendar#New_year