OOjs UI: The Cancel dialog should not have an X (just "Continue editing" and "Discard edits"), and if it does, clicking it shouldn't discard changes
Closed, ResolvedPublic

Description

The 'Cancel' button (or clicking a tab to leave the page) has three buttons:

  1. an X in the upper right corner
  2. "Continue editing"
  3. "Discard edits"

The X probably shouldn't be there at all. However, if it's going to be there, then it should have the same effect as "Continue editing", not "Surprise me by irreversibly discarding all my work when I thought I was just getting rid of the box".


Version: unspecified
Severity: normal

bzimport added a project: OOjs-UI.Via ConduitNov 22 2014, 3:26 AM
bzimport set Reference to bz66851.
Whatamidoing-WMF created this task.Via LegacyJun 19 2014, 4:56 PM
Jdforrester-WMF added a comment.Via ConduitJul 14 2014, 10:44 PM

Fixed in gerrit 139550.

Jdforrester-WMF moved this task to Done on the OOjs-UI workboard.Via WebThu, Mar 26, 9:02 PM

Add Comment

Column Prototype
This is a very early prototype of a persistent column. It is not expected to work yet, and leaving it open will activate other new features which will break things. Press "\" (backslash) on your keyboard to close it now.