VisualEditor: Clicking on "Make full size" switches to Custom tab, keeping the default size and not making it full size on the first attempt for all kind of images
Closed, ResolvedPublic

Description

Steps to reproduce:

1.Open a page with VE
2.Insert an image
3.Open the Media Settings dialog for the image
4.Go to Advanced Settings tab
5.Click on "Make full size"

Observed Result:
It switches to the Custom tab and keeps the size value as default instead of making it full size.

Environment:Betalabs,test2, en.wiki


Version: unspecified
Severity: normal

Details

Reference
bz66863

Change 142171 had a related patch set uploaded by Mooeypoo:
Correctly update full size in MediaSizeWidget

https://gerrit.wikimedia.org/r/142171

Change 142171 merged by jenkins-bot:
Correctly update full size in MediaSizeWidget

https://gerrit.wikimedia.org/r/142171

Verified the fix in betalabs

We need to backport the fix for this one,it did not make it to test2.

Change 142855 had a related patch set uploaded by Jforrester:
Update VisualEditor to Iba4e6b32

https://gerrit.wikimedia.org/r/142855

Change 142855 merged by jenkins-bot:
Update VisualEditor to Iba4e6b32

https://gerrit.wikimedia.org/r/142855

Backported to wmf11 and working great.

Verified the fix on test2

Its changing the size value in the dialog but after clicking on "Apply Changes" button it is not making it full size.So, reopening it .

Change 144637 had a related patch set uploaded by Mooeypoo:
Apply 'original size' to images

https://gerrit.wikimedia.org/r/144637

Change 144638 had a related patch set uploaded by Mooeypoo:
Apply 'original size' to images and enable apply button in ve-MW

https://gerrit.wikimedia.org/r/144638

Change 144638 merged by jenkins-bot:
Apply 'original size' to images and enable apply button in ve-MW

https://gerrit.wikimedia.org/r/144638

Change 144637 merged by jenkins-bot:
Apply 'original size' to images

https://gerrit.wikimedia.org/r/144637

Verified the fix in Betalabs

Verified the fix in test2

Verified the fix in production

Add Comment