Page MenuHomePhabricator

special page delete revision tabindex order incorrect
Closed, ResolvedPublic

Description

On https://it.wikivoyage.org, the page "Speciale:CancellaRevisione" (see as an example this page: https://it.wikivoyage.org/w/index.php?title=Speciale:CancellaRevisione&target=Speciale%3ARegistri%2Fdelete&type=logging&ids=279691) has a wrong tabindex order.

In particular.

  • wpHidePrimary HAS NOT a tabindex
  • wpHideComment HAS NOT a tabindex
  • wpHideUser HAS NOT a tabindex
  • wpRevDeleteReasonList has tabindex=1
  • wpReason HAS NOT a tabindex
  • submit HAS NOT a tabindex
  • search has tabindex=2

Because of this, after the selection of the delete reason, the tab click bring the focus from wpRevDeleteReasonList to search instead of wpReason.

The right tabindex order should be the following:

  • wpHidePrimary: tabindex=1
  • wpHideComment: tabindex=2
  • wpHideUser: tabindex=3
  • wpRevDeleteReasonList: tabindex=4
  • wpReason: tabindex=5
  • submit: tabindex=6
  • search: tabindex=7

PS
I'm not sure 100% but I think that previously this was working fine.

Can someone fix it?


Version: 1.24rc
Severity: normal

Details

Reference
bz67271

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:34 AM
bzimport set Reference to bz67271.

Change 144348 had a related patch set uploaded by IAlex:
Remove tabindex from the drop-down in Special:RevisionDelete

https://gerrit.wikimedia.org/r/144348

Change 144348 had a related patch set uploaded by Bartosz Dziewoński:
Remove tabindex from the drop-down in Special:RevisionDelete

https://gerrit.wikimedia.org/r/144348

Change 144348 merged by jenkins-bot:
Remove tabindex from the drop-down in Special:RevisionDelete

https://gerrit.wikimedia.org/r/144348

A question just to be sure. Considering that currently the behaviour of the tabindexes hasn't changes, is correct to say that fixed doesn't mean deployed?

(In reply to Andyrom75 from comment #4)

A question just to be sure. Considering that currently the behaviour of the
tabindexes hasn't changes, is correct to say that fixed doesn't mean
deployed?

Yes. New versions are deployed on WMF sites according to this schedule:
[[mw:MediaWiki 1.24/Roadmap]]. This fix will be part of version 1.24wmf13.
It is possible to backport a change and deploy it immediately (or within
24 hours, at least), but that's usually reserved for severe bugs affecting
most of readers or editors.

Thanks for the clarification. It's not so urgent indeed; mine was just curiosity.