Page MenuHomePhabricator

VisualEditor: [Regression wmf12] Entering a custom size value in the Advanced Settings dialog for an image does not enable "Apply Changes" button
Closed, ResolvedPublic

Description

Steps to reproduce:

1.Open a page with VE which has an image inside it
2.Open the advanced settings dialog for that image
3.Type something in the Custom fields

Observed Result:
The Apply changes button does not get enabled upon changing the size value, it should change the tab to custom and enable the button

Environment:Betalabs and test2


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=67687

Details

Reference
bz67684

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:27 AM
bzimport set Reference to bz67684.
Ryasmeen created this task.Jul 8 2014, 7:35 PM

It also happens when you reopen an image which was previously has been set to a custom size and try to edit those values.

Change 146676 had a related patch set uploaded by Mooeypoo:
Switch to 'custom' when MediaSizeWidget updates

https://gerrit.wikimedia.org/r/146676

Change 146682 had a related patch set uploaded by Mooeypoo:
Listen to widget changes in MediaDialog

https://gerrit.wikimedia.org/r/146682

Change 146676 merged by jenkins-bot:
Switch to 'custom' when MediaSizeWidget updates

https://gerrit.wikimedia.org/r/146676

Change 146682 merged by jenkins-bot:
Listen to widget changes in MediaDialog

https://gerrit.wikimedia.org/r/146682

Verified the fix in test2

Verified the fix in production en.wiki

  • Bug 68014 has been marked as a duplicate of this bug. ***