Page MenuHomePhabricator

VisualEditor: [Regression pre-wmf14] The cursor stays enabled in readmode after saving a page
Closed, ResolvedPublic



After saving a page,cursor still remains enabled on readmode in Betalabs.

Version: unspecified
Severity: minor




Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 3:33 AM
bzimport set Reference to bz68048.
Ryasmeen created this task.Jul 15 2014, 6:13 PM
  • Bug 68110 has been marked as a duplicate of this bug. ***
  • Bug 68116 has been marked as a duplicate of this bug. ***

<Krenair> So we're not destroying the surface, because the SaveDialog closing promise doesn't get resolved
<Krenair> it's rejected with "Cannot close window: window already closing with different data"
<TrevorParscal> Krenair: that's not good
<TrevorParscal> Krenair: have you identified why it doesn't get resolved?
<Krenair> Not past that error, yet
<Krenair> Even if I check !this.saveDialog.getManager().isClosing() before trying to this.saveDialog.close() it does that
<Krenair> It's fine if I check !this.saveDialog.getManager().closing instead though
<Krenair> well, then I get "Uncaught TypeError: Cannot read property 'getComputedStyle' of undefined", but the surface is torn down
<Krenair> TrevorParscal, want to investigate further?
<TrevorParscal> that's to do with removing the window from the dom before it's done with teardown
<TrevorParscal> I added code in my rewrite which used promises in init to wait for the window to close before removing things, I saw that same error
<TrevorParscal> maybe I missed something?

Change 146984 had a related patch set uploaded by Jforrester:
Close the save dialog on teardown only, not on save

Change 146984 merged by jenkins-bot:
Close the save dialog on teardown only, not on save

Verified the fix in Betalabs

Verified the fix in test2

This is happening again on Betalabs

WFM – BetaLabs hiccup?