Page MenuHomePhabricator

sorting of style modules leading to arbitrary loading of files
Closed, ResolvedPublic

Description

Author: moka

Description:
The order of how CSS files is important. I would argue the order in which style modules are added to the resource loader should be maintained, but it is not (see https://git.wikimedia.org/blob/mediawiki%2Fcore.git/02936f3d9541f524c82283bb81b3c1e57816ce71/includes%2FOutputPage.php#L2710). 'dependencies' also does not work for style modules. Please either allow style modules to be dependent on other modules or take out the sort.


Version: 1.24rc
Severity: normal

Details

Reference
bz69159

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:37 AM
bzimport set Reference to bz69159.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to Moka from comment #0)

The order of how CSS files is important. [...]
'dependencies' also does not work for style modules.

Is there a specific example that you could share?

moka wrote:

(In reply to Andre Klapper from comment #1)

(In reply to Moka from comment #0)

The order of how CSS files is important. [...]
'dependencies' also does not work for style modules.

Is there a specific example that you could share?

Here are the contents of my skin:

skins/TLKWiki/TLKWiki.php
https://ghostbin.com/paste/zaonx

skins/TLKWiki/SkinTLKWiki.php
https://ghostbin.com/paste/uzdp4

skins/TLKWiki/screen.css
(some CSS file)

Here is a link to my wiki http://www.mylionking.com/wiki
I have removed the sort() on the line I linked to in the first post.

  • This bug has been marked as a duplicate of bug 45229 ***