Page MenuHomePhabricator

Recommendations personal tool is dead link for no-JS or unsupported browsers
Closed, ResolvedPublic

Description

For users without JavaScript or in IE 7, the personal tool will be a dead link. It shows, but does nothing except change URL to #recommendations on click.

It needs to be hidden by default, then conditionally shown if it's a supported browser. That should also take care of the no-JS case (If/when we support IE 7, we can switch to the 'client-nojs' class for this, which goes on the body and is removed by JS).


Version: master
Severity: normal

Details

Reference
bz69809

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:29 AM
bzimport set Reference to bz69809.

Change 155447 had a related patch set uploaded by Robmoen:
Hide recommendations in personal tools if js is disabled

https://gerrit.wikimedia.org/r/155447

Change 155447 merged by jenkins-bot:
Add personal tool styles on personal urls hook

https://gerrit.wikimedia.org/r/155447