Page MenuHomePhabricator

VisualEditor: [Regression wmf18] Save Page no longer completes save actions
Closed, ResolvedPublic

Description

Save button not working after creating citation

After fixing https://bugzilla.wikimedia.org/show_bug.cgi?id=69856

Do everything to create a Citation as shown in the screen shot.

Click Save. Save does nothing.


Version: unspecified
Severity: major

Attached:

Details

Reference
bz69864

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:33 AM
bzimport set Reference to bz69864.

This happens while trying to save a page after adding anything in the page, not just citations.The error that appears in the console is:
Uncaught TypeError: Cannot read property 'openWindow' of null

gerritadmin wrote:

Change 155601 had a related patch set uploaded by Jforrester:
Followup 67f304a: use .openWindow(), not .open(), to open save dialog

https://gerrit.wikimedia.org/r/155601

gerritadmin wrote:

Change 155601 merged by jenkins-bot:
Followup 67f304a: use .openWindow(), not .open(), to open save dialog

https://gerrit.wikimedia.org/r/155601

Verified the fix in production