Page MenuHomePhabricator

Performance review of SandboxLink extension
Closed, DeclinedPublic

Description


Version: unspecified
Severity: normal

Details

Reference
bz70501

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:55 AM
bzimport set Reference to bz70501.
bzimport added a subscriber: Unknown Object (MLST).

There are only two things which could conceivably lead to performance
issues and I believe I've taken care of both of them.

  1. Adding the personal sandbox link is (by default) disabled for anonymous users, whose page views are usually cached.
  2. The extension uses the SkinPreloadExistence hook to avoid additional database queries about page existence status.
Aklapper subscribed.

So who could review this? Assignee welcome.

I think Ori was going to sign off on it.

We don't require performance reviews pre-deployment anymore, so removing this as a blocker.

(Clearly no one is going to do this.)