Page MenuHomePhabricator

casechecker i18n coding error
Closed, ResolvedPublic

Description

Bug 55022 added casechecker.py to the i18n repo.

In new line 406

http://git.wikimedia.org/blobdiff/pywikibot%2Fcompat.git/d5a3b0349e0264a298d909d03455283f3f154fb2/casechecker.py

pywikibot.translate is replaced with i18n.twtranslate, but the parameters were not completely changed. It now calls twtranslate with four parameters, however twtranslate only supports three parameters

newText = i18n.twtranslate(
    self.site,
    "casechecker-delete-reason", redirTitle,
    fallback=False)

i18n.py:

def twtranslate(code, twtitle, parameters=None):


Version: unspecified
Severity: major

Details

Reference
bz70596

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:44 AM
bzimport set Reference to bz70596.

gerritadmin wrote:

Change 159471 had a related patch set uploaded by Xqt:
(bug 70596) fix i18n.twtranslate call

https://gerrit.wikimedia.org/r/159471

gerritadmin wrote:

Change 159472 had a related patch set uploaded by Xqt:
(bug 70596) fix i18n.twtranslate call

https://gerrit.wikimedia.org/r/159472

gerritadmin wrote:

Change 159472 merged by jenkins-bot:
(bug 70596) fix i18n.twtranslate call

https://gerrit.wikimedia.org/r/159472

gerritadmin wrote:

Change 159471 merged by jenkins-bot:
(bug 70596) fix i18n.twtranslate call

https://gerrit.wikimedia.org/r/159471