Page MenuHomePhabricator

VisualEditor: ”Use an Existing Reference“ button should be inactive if there are no references to add (the internal list is empty)
Closed, ResolvedPublic

Description

screenshot1

Environment-test2,beta, production.

1> open a page in VE, add a Basic citation.
2>Click to add Basic citation again ,in the modal click on “Use an Existing Reference “.Select the citation that you just added.
3>In the editor pane, delete all the citations.
4> Select to add Basic citation again. In the modal notice the “Use an Existing Reference “ button is still active, although there are no citations to add to. Click on it and it opens a blank Reference modal.
See screenshot.


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz70611

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz70611.
Swainr created this task.Sep 9 2014, 4:06 PM

gerritadmin wrote:

Change 159423 had a related patch set uploaded by Alex Monk:
Properly mark reference search index as empty when setting internal list

https://gerrit.wikimedia.org/r/159423

gerritadmin wrote:

Change 159423 merged by jenkins-bot:
Properly mark reference search index as empty when setting internal list

https://gerrit.wikimedia.org/r/159423

The Re-Use option in the Cite menu from the toolbar still remains enabled when there is no reference in the article.

This bug is about a very specific way to break the existing disabling of a different button. What you propose makes sense but it's not in scope here. I'll take a look into doing it anyway, but I'm going to re-close this bug.

(Opened bug 70640 for that)

Verified the fix in test2

Verified the fix in production