Page MenuHomePhabricator

StorageException in EditEntityActionTest::testActionForPage (edit-already-exists) and related failures
Closed, ResolvedPublic

Description

I am getting a bunch of tests failures related to not stuff not found (e.g. not able to create it or whatnot).

Apparently these are failing only for me, but not sure? Maybe something is trying to write to my non-test database tables and conflicts with existing content? or something to do with my settings or other extensions that I have enabled?

anyway, this is annoying.

  1. Wikibase\Test\EditEntityActionTest::testActionForPage

Wikibase\Lib\Store\StorageException: (edit-already-exists)

/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/store/sql/WikiPageEntityStore.php:226
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/store/sql/WikiPageEntityStore.php:148
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:354
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:346
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:304
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:279
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:471
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:495
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:55
/Library/WebServer/Documents/php-master/tests/phpunit/MediaWikiTestCase.php:133

  1. Wikibase\Test\EditEntityActionTest::testUndoForm with data set #14 ('edit', XXX, array(array('London', 0)), false, NULL, '/missing-article/')

Exception: unknown test item: London

/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:474
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:495
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:70
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:655
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:322
/Library/WebServer/Documents/php-master/tests/phpunit/MediaWikiTestCase.php:133

  1. Wikibase\Test\EditEntityActionTest::testUndoForm with data set #15 ('edit', 'Berlin', array(array('London', 0)), false, NULL, '/wikibase-undo-badpage/')

Exception: unknown test item: London

/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:474
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:495
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:70
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:653
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:322
/Library/WebServer/Documents/php-master/tests/phpunit/MediaWikiTestCase.php:133

  1. Wikibase\Test\EditEntityActionTest::testUndoForm with data set #16 ('edit', 'Berlin', array(array('London', -1)), false, NULL, '/wikibase-undo-badpage/')

Exception: unknown test item: London

/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:474
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:495
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:70
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:654
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:322
/Library/WebServer/Documents/php-master/tests/phpunit/MediaWikiTestCase.php:133

  1. Wikibase\Test\EditEntityActionTest::testUndoForm with data set #17 ('edit', 'Berlin', array(array('London', -1)), false, NULL, '/wikibase-undo-badpage/')

Exception: unknown test item: London

/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:474
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:495
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:70
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:655
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:322
/Library/WebServer/Documents/php-master/tests/phpunit/MediaWikiTestCase.php:133

  1. Wikibase\Test\EditEntityActionTest::testUndoForm with data set #18 ('edit', 'Berlin2', array(0), false, NULL, '/undo-success/')

Exception: unknown test item: Berlin2

/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:474
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:495
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:648
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:322
/Library/WebServer/Documents/php-master/tests/phpunit/MediaWikiTestCase.php:133

  1. Wikibase\Test\EditEntityActionTest::testUndoSubmit with data set #8 ('submit', 'Berlin', array(1, true, -1), true, NULL, NULL, array('![:/=]Q\\d+$!'))

Wikibase\Lib\Store\StorageException: (edit-already-exists)

/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/store/sql/WikiPageEntityStore.php:226
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/store/sql/WikiPageEntityStore.php:148
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:354
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:346
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:304
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:421
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:629
/Library/WebServer/Documents/php-master/tests/phpunit/MediaWikiTestCase.php:133

  1. Wikibase\Test\EditEntityActionTest::testUndoSubmit with data set #9 ('submit', 'Berlin', array(1, true, 0), true, NULL, '/wikibase-undo-samerev/')

Wikibase\Lib\Store\StorageException: (edit-already-exists)

/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/store/sql/WikiPageEntityStore.php:226
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/store/sql/WikiPageEntityStore.php:148
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:354
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:346
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:304
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:421
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:623
/Library/WebServer/Documents/php-master/tests/phpunit/MediaWikiTestCase.php:133

  1. Wikibase\Test\EditEntityActionTest::testUndoSubmit with data set #14 ('submit', XXX, array(1, true, array('London', 0)), true, NULL, '/missing-article/')

Exception: unknown test item: London

/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:474
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:495
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:70
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:655
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:626
/Library/WebServer/Documents/php-master/tests/phpunit/MediaWikiTestCase.php:133

  1. Wikibase\Test\EditEntityActionTest::testUndoSubmit with data set #15 ('submit', 'Berlin', array(1, true, array('London', 0)), true, NULL, '/wikibase-undo-badpage/')

Exception: unknown test item: London

/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:474
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:495
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:70
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:653
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:626
/Library/WebServer/Documents/php-master/tests/phpunit/MediaWikiTestCase.php:133

  1. Wikibase\Test\EditEntityActionTest::testUndoSubmit with data set #16 ('submit', 'Berlin', array(1, true, array('London', -1)), true, NULL, '/wikibase-undo-badpage/')

Exception: unknown test item: London

/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:474
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:495
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:70
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:654
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:626
/Library/WebServer/Documents/php-master/tests/phpunit/MediaWikiTestCase.php:133

  1. Wikibase\Test\EditEntityActionTest::testUndoSubmit with data set #17 ('submit', 'Berlin', array(1, true, array('London', -1)), true, NULL, '/wikibase-undo-badpage/')

Exception: unknown test item: London

/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:474
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:495
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:70
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:655
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:626
/Library/WebServer/Documents/php-master/tests/phpunit/MediaWikiTestCase.php:133

  1. Wikibase\Test\EditEntityActionTest::testUndoRevisions with data set #3 ('Berlin', array(-2), array(array('Stadt in Deutschland')))

Wikibase\Lib\Store\StorageException: (edit-already-exists)

/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/store/sql/WikiPageEntityStore.php:226
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/store/sql/WikiPageEntityStore.php:148
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:354
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:346
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:304
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:421
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/EditEntityActionTest.php:813
/Library/WebServer/Documents/php-master/tests/phpunit/MediaWikiTestCase.php:133

  1. Wikibase\Test\ViewEntityActionTest::testShow with data set #1 ('Berlin2', '/redirectMsg/')

Exception: unknown test item: Berlin2

/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:474
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ActionTestCase.php:495
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/actions/ViewEntityActionTest.php:64
/Library/WebServer/Documents/php-master/tests/phpunit/MediaWikiTestCase.php:133

  1. Wikibase\Test\Api\SetClaimTest::testAddInvalidClaim

[data-update-failed]: A data update callback triggered an exception (DatabaseBase::deadlockLoop: Transaction already in progress (from WikiPage::doDeleteArticleReal), performing implicit commit! [Called from DatabaseBase::begin in /Library/WebServer/Documents/php-master/includes/db/Database.php at line 3458]) [Called from Wikibase\Updates\DataUpdateAdapter::doUpdate in /Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/updates/DataUpdateAdapter.php at line 73]

/Library/WebServer/Documents/php-master/includes/debug/MWDebug.php:302
/Library/WebServer/Documents/php-master/includes/debug/MWDebug.php:157
/Library/WebServer/Documents/php-master/includes/GlobalFunctions.php:1172
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/lib/includes/Reporting/LogWarningExceptionHandler.php:30
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/updates/DataUpdateAdapter.php:73
/Library/WebServer/Documents/php-master/includes/deferred/DataUpdate.php:101
/Library/WebServer/Documents/php-master/includes/page/WikiPage.php:2918
/Library/WebServer/Documents/php-master/includes/page/WikiPage.php:2879
/Library/WebServer/Documents/php-master/includes/page/WikiPage.php:2747
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/store/sql/WikiPageEntityStore.php:291
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/api/SetClaimTest.php:185
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/api/SetClaimTest.php:238
/Library/WebServer/Documents/php-master/tests/phpunit/MediaWikiTestCase.php:133

  1. Wikibase\Test\EntityPerPageBuilderTest::testRebuildAll

Wikibase\Lib\Store\StorageException: Could not create a new page.
It already exists.

/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/store/sql/WikiPageEntityStore.php:226
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/store/sql/WikiPageEntityStore.php:148
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/store/sql/EntityPerPageBuilderTest.php:123
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/store/sql/EntityPerPageBuilderTest.php:53
/Library/WebServer/Documents/php-master/tests/phpunit/MediaWikiTestCase.php:133

  1. Wikibase\Test\EntityPerPageBuilderTest::testRebuildPartial

Wikibase\Lib\Store\StorageException: Could not create a new page.
It already exists.

/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/store/sql/WikiPageEntityStore.php:226
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/store/sql/WikiPageEntityStore.php:148
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/store/sql/EntityPerPageBuilderTest.php:123
/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/tests/phpunit/includes/store/sql/EntityPerPageBuilderTest.php:53
/Library/WebServer/Documents/php-master/tests/phpunit/MediaWikiTestCase.php:133


Version: unspecified
Severity: minor

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:52 AM
bzimport set Reference to bz70710.
bzimport added a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).

There are numerous phpunit tests in Wikibase that use database access but do not have @group Database tags. This is likely the problem.

Change 193133 had a related patch set uploaded (by Aude):
Add @group Database to repo tests that access the db

https://gerrit.wikimedia.org/r/193133

Change 193275 had a related patch set uploaded (by Aude):
Add more @group Database tags to repo tests

https://gerrit.wikimedia.org/r/193275

Change 193120 had a related patch set uploaded (by Aude):
Add @group Database tags to lib tests that use database

https://gerrit.wikimedia.org/r/193120

Change 194336 had a related patch set uploaded (by Aude):
Add @group Database where needed in client

https://gerrit.wikimedia.org/r/194336

Change 194336 merged by jenkins-bot:
Add @group Database where needed in client

https://gerrit.wikimedia.org/r/194336

Change 193133 merged by jenkins-bot:
Add @group Database to repo tests that access the db

https://gerrit.wikimedia.org/r/193133

Change 193120 merged by jenkins-bot:
Add @group Database tags to lib tests that use database

https://gerrit.wikimedia.org/r/193120

Change 193275 merged by jenkins-bot:
Add more @group Database tags to repo tests

https://gerrit.wikimedia.org/r/193275