Page MenuHomePhabricator

"Remove from course" button no longer works
Closed, ResolvedPublic

Description

Users with advanced rights have an option to remove users as students from a course page: the "remove from course" link in the students table brings a confirmation dialog, and normally when you click "Remove student" to confirm it, the user is removed from the course.

As noticed today, this no longer works. After clicking "Remove student", the user remains listed as a student.


Version: unspecified
Severity: major

Details

Reference
bz70748

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz70748.
bzimport added a subscriber: Unknown Object (MLST).

The similar "remove as reviewer" link, which uses the same type of popup confirmation dialog, still works. (Thus, maybe it's not a javascript problem?)

Also, the enrolled user can still remove themselves using the Disenroll button from the top right tabs overflow pulldown ("More").

andrew.green.df wrote:

I was able to reproduce this locally with core and the EducationProgram extension at version MediaWiki 1.24wmf21.

andrew.green.df wrote:

The problem comes from recent changes in ApiBase:

https://gerrit.wikimedia.org/r/#/c/153110/

Still running into a few obstacle in getting it to work. I'll post more if I'm not successful soon...

Change 160901 had a related patch set uploaded by AndyRussG:
Fix RemoveStudentAction after API token overhaul

https://gerrit.wikimedia.org/r/160901

Change 160901 merged by jenkins-bot:
Fix RemoveStudentAction after API token overhaul

https://gerrit.wikimedia.org/r/160901

vojtech.dostal wrote:

Hi, the same problem occurs on Czech Wikipedia. Can you estimate when this gets solved?

@vojtech: The fix got merged last week before the new deployment branch, which means it should go live this Thursday.

vojtech.dostal wrote:

@sage Thank you for information, that's brilliant:)