Page MenuHomePhabricator

Bucketing not working correctly for recommendations
Closed, ResolvedPublic

Description

Author: swalling

Description:
Per reports from https://de.wikipedia.org/wiki/Wikipedia_Diskussion:Kurier#Empfehlungen it appears that some users with accounts that are definitely not new are receiving both the post-edit recommendation and the flyout.

Strangely, this issue does not appear with accounts on English Wikipedia. This is true even for the same accounts on the other wiki (as tested by Eloquence.)


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=22097

Details

Reference
bz70759

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 3:55 AM
bzimport set Reference to bz70759.
bzimport created this task.Sep 12 2014, 8:06 AM

My bet is that the tool does not check if there is NO account-creation-date.

Yes, it seems that all affected user does not have a date in the user_registration field on the user table. When using the wrong method in mediawiki the NULL from the database gets handled as a now.

In other words User::getRegistration can return null and needs use of wfTimestampOrNull() instead of wfTimestamp() to get the unix timestamp (or null).

The feature has been disabled for *all* users in [[de:MediaWiki:Common.css]] because of this bug, so please don't be surprised if you won't get any testing results from dewiki.

swalling wrote:

(In reply to entlinkt from comment #3)

The feature has been disabled for *all* users in [[de:MediaWiki:Common.css]]
because of this bug, so please don't be surprised if you won't get any
testing results from dewiki.

This disables only the notification you see after every edit. The recommendations link in the personal toolbar (Empfehlungen) should still be present. You can, of course, use CSS to turn either off in your personal skin settings.

swalling wrote:

(In reply to Steven Walling from comment #0)

Per reports from
https://de.wikipedia.org/wiki/Wikipedia_Diskussion:Kurier#Empfehlungen it
appears that some users with accounts that are definitely not new are
receiving both the post-edit recommendation and the flyout.
Strangely, this issue does not appear with accounts on English Wikipedia.
This is true even for the same accounts on the other wiki (as tested by
Eloquence.)

Confirmed also on French Wikipedia.

-jkb- added a comment.Sep 12 2014, 4:35 PM

That's right. I get it on dewiki only.

Change 160044 had a related patch set uploaded by Mattflaschen:
Exclude users with null user_registration

https://gerrit.wikimedia.org/r/160044

Change 160044 merged by jenkins-bot:
Exclude users with null user_registration

https://gerrit.wikimedia.org/r/160044

Change 160083 had a related patch set uploaded by Mattflaschen:
Exclude users with null user_registration

https://gerrit.wikimedia.org/r/160083

Change 160084 had a related patch set uploaded by Mattflaschen:
Exclude users with null user_registration

https://gerrit.wikimedia.org/r/160084

Change 160083 merged by jenkins-bot:
Exclude users with null user_registration

https://gerrit.wikimedia.org/r/160083

Change 160084 merged by jenkins-bot:
Exclude users with null user_registration

https://gerrit.wikimedia.org/r/160084

swalling wrote:

Patch merged and deployed. Please do a hard refresh to test, after we update Common.css.

(In reply to Steven Walling from comment #13)

Patch merged and deployed. Please do a hard refresh to test, after we update
Common.css.

Sorry for the miscommunication. The deployment is not complete yet. I'll post here when it is.

(In reply to Matthew Flaschen from comment #14)

(In reply to Steven Walling from comment #13)

Patch merged and deployed. Please do a hard refresh to test, after we update
Common.css.

Sorry for the miscommunication. The deployment is not complete yet. I'll
post here when it is.

It's complete now and Common.css is updated.

Also reported on it.wiki by valepert and others.