e.g. by including a small part of DBAL in QueryEngine
Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=2 s=2014-10-28
Description
Description
Details
Details
- Reference
- bz71503
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T52911 Support transitive queries | |||
| Resolved | None | T54387 Special page for querying by one property and value | |||
| Declined | Lydia_Pintscher | T54385 Query by one property and one value ("simple queries") (tracking) | |||
| Invalid | Lydia_Pintscher | T73501 [Task] Update QueryEngine to use WB DB again | |||
| Resolved | None | T73503 Investigate how to prevent schema definition code from breaking |
Event Timeline
Comment Actions
Only including a small part of DBAL in QE is feasable, though will likely result in the same complaints.
Since we do not need to actually run the code that depends on the DBAL schema stuff on WMF infrastructure, we can simply delete DBAL and things will still work fine (assuming the query code got updated per bug 71501). There are two TODOs at present:
- We need to be able to verify things will be fine by running the tests for the functionality we will be using. This means we need to be able to run the tests without the schema code ones. Adding "@group StoreSchema" to the relevant test methods, and running the tests with "phpunit --exclude-group StoreSchema,performance" achieves this.
- There is actually _some_ query code that ends up invoking code currently bound to the DBAL schema classes (the fetching of the table name). That needs to be worked around, but should be easy, esp once the tests are tagged appropriately.