Page MenuHomePhabricator
Create Task
Maniphest T73548

Duplicate message occasionally sent due to redirects not being de-duped properly
Closed, ResolvedPublicBUG REPORT
Actions

Description

In some cases, a non-trivial subset of the recipients receives a message twice (usually in the same minute): see example in URL. This might have to do with replag and/or job queue problems and/or something else, because something similar happens in TranslationNotifications as well (bug 69940).

Version: unspecified
Severity: normal
URL: https://ba.wikipedia.org/w/index.php?title=%D2%A0%D0%B0%D1%82%D0%BD%D0%B0%D1%88%D1%8B%D1%83%D1%81%D1%8B_%D0%BC%D0%B5%D0%BD%D3%99%D0%BD_%D2%BB%D3%A9%D0%B9%D0%BB%D3%99%D1%88%D0%B5%D2%AF:Haqmar&offset=20141002075536&limit=2&action=history
See Also:
T71940: Duplicate talk page translation notifications sent to some users

Details

Reference
bz71548

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:56 AM
• bzimport added a project: MassMessage.
• bzimport set Reference to bz71548.
• bzimport added a subscriber: Unknown Object (MLST).
Nemo_bis created this task.Oct 2 2014, 7:59 AM
Legoktm added a comment.Oct 3 2014, 7:13 AM

This appears to be because we aren't de-duping redirects: https://ba.wikipedia.org/w/index.php?title=%D2%A0%D0%B0%D1%82%D0%BD%D0%B0%D1%88%D1%8B%D1%83%D1%81%D1%8B_%D0%BC%D0%B5%D0%BD%D3%99%D0%BD_%D2%BB%D3%A9%D0%B9%D0%BB%D3%99%D1%88%D0%B5%D2%AF:HaqmarBot&redirect=no so two messages were sent.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2015, 5:02 PM
Reedy removed a subscriber: • wikibugs-l-list.Nov 29 2015, 2:06 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 29 2015, 2:06 PM
Nikerabbit mentioned this in T71940: Duplicate talk page translation notifications sent to some users.Jun 7 2016, 8:59 AM
Liuxinyu970226 updated the task description. (Show Details)Mar 15 2017, 4:01 PM
Aklapper mentioned this in T270873: Fix Massmessage duplicated posting.Dec 28 2020, 4:07 PM
Teles subscribed.Dec 28 2020, 5:13 PM
Nikerabbit moved this task from Backlog to Message delivery on the MassMessage board.Jan 26 2022, 9:58 AM
Aklapper triaged this task as Low priority.Feb 4 2022, 8:07 PM
Aklapper changed the subtype of this task from "Task" to "Bug Report".
Dreamy_Jazz closed this task as Resolved.Dec 14 2022, 2:32 PM
Dreamy_Jazz subscribed.

It seems that there is proper redirect detection now. Testing on my local wiki suggests that if a redirect goes to a place that is already a target it will remove it before sending the message. As such I'm marking this as resolved. Feel free to undo if I've missed a edge-case.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL