Page MenuHomePhabricator
Create Task
Maniphest T73768

UploadWizard should not register ResourceLoaderFileModule objects
Closed, ResolvedPublic
Actions

Description

In UploadWizardHooks::resourceLoaderRegisterModules(), the modules are registered with an object. They should instead just be registered with the definition array, and let RL convert them to objects whenever needed.

Version: unspecified
Severity: normal

Details

Reference
bz71768

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:52 AM
• bzimport added projects: UploadWizard, good first task.
• bzimport set Reference to bz71768.
• bzimport added a subscriber: Unknown Object (MLST).
Legoktm created this task.Oct 7 2014, 11:09 PM
gerritbot added a comment.Oct 11 2014, 6:12 PM

Change 166202 had a related patch set uploaded by Legoktm:
Don't register ResourceLoaderFileModule objects

https://gerrit.wikimedia.org/r/166202

gerritbot added a comment.Oct 13 2014, 1:03 PM

Change 166202 merged by jenkins-bot:
Don't register ResourceLoaderFileModule objects

https://gerrit.wikimedia.org/r/166202

Aklapper added a comment.Nov 15 2014, 12:16 PM

All patches mentioned in this report were merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

• Gilles added a project: Multimedia.Dec 4 2014, 9:22 AM
• Gilles moved this task from Untriaged to Done on the Multimedia board.Dec 4 2014, 9:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits