Page MenuHomePhabricator
Create Task
Maniphest T73926

Fix or remove GuidedTour preloading
Open, LowPublicBUG REPORT
Actions

Description

The preloading at https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGuidedTour.git/7018887bceb7603496ee70a6a4a4664522078029/modules%2Fmediawiki.libs.guiders%2Fmediawiki.libs.guiders.js#L776 is broken, since it treats guider.next as a string whereas it's now a function (https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGuidedTour.git/7018887bceb7603496ee70a6a4a4664522078029/modules%2Fext.guidedTour.lib%2Fext.guidedTour.lib.Step.js#L852).

Luckily, there is sanity check to make sure the ID is defined. Since the function shouldn't appear in that associative array, it should correctly fallback to just not pre-loading.

We can probably just remove this functionality for now.

Version: master
Severity: normal

Details

Reference
bz71926

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:46 AM
• bzimport added a project: MediaWiki-extensions-GuidedTour.
• bzimport set Reference to bz71926.
• bzimport added a subscriber: Unknown Object (MLST).
• Mattflaschen-WMF created this task.Oct 11 2014, 12:49 AM
Reedy removed a subscriber: • wikibugs-l-list.Nov 29 2015, 2:06 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 29 2015, 2:06 PM
• Deskana renamed this task from Fix or remove GuidedTour preloading to VisualEditor.Aug 30 2018, 1:30 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 30 2018, 1:30 PM
• Deskana renamed this task from VisualEditor to Fix or remove GuidedTour preloading.Aug 30 2018, 1:40 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 7:05 PM
Aklapper triaged this task as Low priority.Feb 4 2022, 8:07 PM
Aklapper changed the subtype of this task from "Task" to "Bug Report".
Aklapper removed subscribers: • rmoen, • Mattflaschen-WMF.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL