Page MenuHomePhabricator

Deprecated mediawiki JS methods should have console warnings (like jQuery methods)
Closed, DeclinedPublic

Description

Exhibit A: https://gerrit.wikimedia.org/r/168419

Caused, I think, by deprecation of the { ok: ..., err: ... } way of setting callbacks in mw.Api, but not totally sure. If that *is* the reason, then we never saw any warnings about it to my knowledge...

It may just be that we missed it, but if not, I figured it should be raised that a warning would be nice.

Details

Reference
bz72451

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:46 AM
bzimport set Reference to bz72451.
bzimport added a subscriber: Unknown Object (MLST).

They were deprecated since MediaWiki 1.23. Deprecation warnings added in October 2013. Removed October 2014 (MediaWiki 1.25).

Various mailing lists were notified of deprecation warnings being introduced, call to migration several times, and at the actual removal (wikitech-l, mediawiki-l, wikitech-ambassadors, engineering-l) for Wikimedia.

The console warnings were also tracked in EventLogging (graphite):

graphite.wikimedia.png (400×900 px, 40 KB)

https://www.mail-archive.com/wikitech-l%40lists.wikimedia.org/msg72198.html
https://www.mail-archive.com/wikitech-l%40lists.wikimedia.org/msg78108.html

Krinkle renamed this task from Deprecation warnings may not be consistent for jQuery to Deprecated mediawikii JS methods should have console warnings (like jQuery methods).Dec 31 2014, 6:06 PM
Krinkle renamed this task from Deprecated mediawikii JS methods should have console warnings (like jQuery methods) to Deprecated mediawiki JS methods should have console warnings (like jQuery methods).
Krinkle closed this task as Declined.
Krinkle updated the task description. (Show Details)
Krinkle added a project: JavaScript.
Krinkle set Security to None.
Krinkle removed a subscriber: Unknown Object (MLST).

Something we could do perhaps, is to do sampled logging of the stack for deprecated functions ?
Then we can gather the remaining locations that are triggering the deprecations.

We already gather some data about the callers (though not stack traces). However it's all in the EventLogging database. Only the counts can be exposed publicly, of course. Especially in Graphite where we have to aggregate it.

Once collected, we can make a few dumps of callers though. Patch/Task welcome :)