Page MenuHomePhabricator

Hygiene: Ajax loader on notifications icon should be a real Icon
Closed, ResolvedPublic

Description

In notifications.js an Icon is created which has no name. An additionalClass loading is what renders the icon. Introduced in patch https://gerrit.wikimedia.org/r/#/c/172425/

We should create mw-ui-icon-ajax (or icon-ajax for stable/beta)
On a side note: Icon class should throw an error if no name parameter is given.


Version: unspecified
Severity: normal

Details

Reference
bz73251

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:48 AM
bzimport set Reference to bz73251.

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/edxeE6B4

Florian closed this task as Resolved.Dec 2 2014, 11:05 AM
Florian added a subscriber: Florian.

This should be fixed with https://gerrit.wikimedia.org/r/172743/