The <accesskey-save> (Ctrl+Alt+S) keyboard shortcut opens the Save dialog but should also trigger save when in it
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Eloquence
	Nov 27 2014, 9:11 PM

Description

Saving quick edits in wikitext is a bit faster because 1) I don't get the save modal, 2) I can do it with a single keyboard shortcut. Whether or not there's a better answer than the modal, I would like to at least be able to quickly save by pressing Alt+Shift+S twice from the editor.

Details

	Subject	Repo	Branch	Lines +/-
	Set 's' accesskey on save button inside save dialog	mediawiki/extensions/VisualEditor	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned In: T121183: The <accesskey-save> keyboard shortcut doesn't trigger save in the Save dialog in (?) newer versions of Firefox
rEVED0d0172d43bcd: Set 's' accesskey on save button inside save dialog

Event Timeline

Eloquence created this task.Nov 27 2014, 9:11 PM

Eloquence raised the priority of this task from to Needs Triage.

Eloquence updated the task description. (Show Details)

Eloquence changed Security from none to None.

Eloquence added a project: VisualEditor.

Eloquence subscribed.

Krenair subscribed.Nov 27 2014, 10:41 PM

Liuxinyu970226 subscribed.Nov 28 2014, 12:10 AM

Jdforrester-WMF renamed this task from Save dialog should have keyboard shortcut to The <accesskey-save> (Ctrl+Alt+S) keyboard shortcut opens the Save dialog but should also trigger save when in it.Nov 29 2014, 2:21 AM

Jdforrester-WMF triaged this task as Medium priority.

Jdforrester-WMF added a project: VisualEditor-MediaWiki.

Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.

[27-11-2014 22:48:38] <Krenair> I guess it could be achieved with this.getActions().get( { actions: 'save' } )[0].$button.attr( 'accesskey', 's' ); while changing to the save panel
[27-11-2014 22:48:45] <Krenair> but ew.

In T76161#800066, @Krenair wrote:

[27-11-2014 22:48:38] <Krenair> I guess it could be achieved with this.getActions().get( { actions: 'save' } )[0].$button.attr( 'accesskey', 's' ); while changing to the save panel
[27-11-2014 22:48:45] <Krenair> but ew.

I hear your "ew" and raise you $( '#ca-edit' ).text() ;-)

https://gerrit.wikimedia.org/r/#/c/176071/2/modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js

Change 179988 had a related patch set uploaded (by Alex Monk):
Set 's' accesskey on save button inside save dialog

https://gerrit.wikimedia.org/r/179988

Patch-For-Review

Krenair claimed this task.Dec 15 2014, 9:08 PM

Jdforrester-WMF moved this task from TR6: Visual diffs to Blocked on the VisualEditor board.Dec 15 2014, 9:19 PM

Change 179988 merged by jenkins-bot:
Set 's' accesskey on save button inside save dialog

https://gerrit.wikimedia.org/r/179988

Krenair mentioned this in rEVED0d0172d43bcd: Set 's' accesskey on save button inside save dialog.Dec 16 2014, 6:58 PM

Jdforrester-WMF closed this task as Resolved.Dec 16 2014, 6:59 PM

Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.

Jdforrester-WMF added a project: WMF-deploy-2014-12-17_(1.25wmf13).

Liuxinyu970226 unsubscribed.Dec 17 2014, 1:34 AM

Jdforrester-WMF removed a project: Patch-For-Review.Jan 7 2015, 9:25 PM

Ricordisamoa subscribed.Jan 11 2015, 12:12 AM

Jdforrester-WMF added a project: VisualEditor pre-2015 work.Aug 5 2015, 12:58 AM

Shortcut does not work fine.
When dialog is displayed, if I press ALT+MAJ+S focus is given to the blue button "Save the page" in background. If I press a second time ALT+MAJ+S, focus is given to green button "Save". Focus switch between both buttons as pressing ALT+MAJ+S.
So, to save the page, I have to press twice ALT+MAJ+S then press Enter or Spacebar.

I use Firefox 42 on Fedora.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 1 2015, 7:57 PM

Enterprisey subscribed.Dec 7 2015, 1:29 AM

Enterprisey awarded a token.Dec 7 2015, 1:36 AM