Maniphest T76276

diff library problem with 2.6 and 2.7.0
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jayvdb
	Nov 30 2014, 12:08 AM

Tags

Referenced Files

None

Subscribers

pywikibot-bugs-list

Description

File "core\pywikibot\diff.py", line 68,
in get_header
    a_rng = difflib._format_range_unified(*self.a_rng)
AttributeError: 'module' object has no attribute '_format_range_unified'

Pywikibot: [https] r-pywikibot-core.git (2e815ab, g4660, 2014/11/29, 17:39:00, ok)
Release version: 2.0b3
httplib2 version: 0.9
  cacerts: C:\Python27\lib\site-packages\httplib2\cacerts.txt
    certificate test: ok
Python: 2.7 (r27:82525, Jul  4 2010, 07:43:08) [MSC v.1500 64 bit (AMD64)]
  unicode test: triggers problem #3081100

Details

	Subject	Repo	Branch	Lines +/-
	[FIX] Diff: Support Python < 2.7.2	pywikibot/core	master	+83 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid		None	T72987 Python 2.6 issues (tracking)
		Resolved		XZise	T76276 diff library problem with 2.6 and 2.7.0

Event Timeline

jayvdb created this task.Nov 30 2014, 12:08 AM

jayvdb raised the priority of this task from to Needs Triage.

jayvdb updated the task description. (Show Details)

jayvdb changed Security from none to None.

jayvdb subscribed.

jayvdb assigned this task to Mpaa.Nov 30 2014, 10:31 AM

jayvdb added a project: Pywikibot.

jayvdb updated the task description. (Show Details)

IMO we can simply reject 2.7[.0], and update

https://www.mediawiki.org/wiki/Manual:Pywikibot/Version_table

Or we implement something like this https://github.com/jedie/django-reversion-compare/commit/f24648dec35f043d0d8d0b4310418c7c1f17a3bc because it also fails in 2.6.

Change 176499 had a related patch set uploaded (by XZise):
[FIX] Diff: Support Python 2.6 and 2.7.0

https://gerrit.wikimedia.org/r/176499

Patch-For-Review

jayvdb renamed this task from diff library problem with 2.7 to diff library problem with 2.6 and 2.7.0.Nov 30 2014, 11:38 AM

Change 176499 merged by jenkins-bot:
[FIX] Diff: Support Python < 2.7.2

https://gerrit.wikimedia.org/r/176499

XZise closed this task as Resolved.Nov 30 2014, 11:40 PM

XZise claimed this task.

XZise removed a project: Patch-For-Review.

XZise mentioned this in rPWBCf1c1ae4c4b6a: [FIX] Diff: Support Python < 2.7.2.Mar 4 2015, 8:46 AM