Page MenuHomePhabricator

RTL: Topic title has an extra margin in topic title bar
Closed, ResolvedPublic

Description

On our test page on Hebrew WP:

https://he.wikipedia.org/wiki/%D7%A9%D7%99%D7%97%D7%AA_%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94:%D7%96%D7%A8%D7%99%D7%9E%D7%94

The topic title appears to have an extra margin on the right, creating an extra space. The title should line up with the rest of the topic title bar, as it does in English etc.

https://bugzilla.wikimedia.org/show_bug.cgi?id=61440


Trello card: hK8s2iJR

Event Timeline

Spage raised the priority of this task from to Medium.Dec 3 2014, 12:06 PM

Remaining part is to stop using !important here, since it isn't needed.

Change 177465 had a related patch set uploaded (by EBernhardson):
Hygiene: increase specificity of .flow-topic-title and remove !important

https://gerrit.wikimedia.org/r/177465

Patch-For-Review

Change 177469 had a related patch set uploaded (by EBernhardson):
Hygiene: Increase specificity of selector in .flow-topic-summary and remove !important

https://gerrit.wikimedia.org/r/177469

Patch-For-Review

Change 177472 had a related patch set uploaded (by EBernhardson):
Hygiene: Increase specificity of api interaction selectors and remove !important

https://gerrit.wikimedia.org/r/177472

Patch-For-Review

Change 177473 had a related patch set uploaded (by EBernhardson):
Hygiene: Remove !important from .flow-revision-content

https://gerrit.wikimedia.org/r/177473

Patch-For-Review

After the above set of patches there are two remaining places with !imporatant:

  1. collapser.less. This code is going away in the TOC stack so i didn't even look at it.
  1. tooltips.less. This uses !important for the '.flow-ui-tooltip a' selector. TBH this seems fine to me as its a top level generic element that should just be able to override the link color regardless of what its wrapped inside. But maybe others disagree :)

Change 177473 merged by jenkins-bot:
Hygiene: Remove !important from .flow-revision-content

https://gerrit.wikimedia.org/r/177473

Change 177469 merged by jenkins-bot:
Hygiene: Increase specificity of selector in .flow-topic-summary and remove !important

https://gerrit.wikimedia.org/r/177469

Change 177472 merged by jenkins-bot:
Hygiene: Increase specificity of api interaction selectors and remove !important

https://gerrit.wikimedia.org/r/177472

Change 177465 merged by jenkins-bot:
Hygiene: increase specificity of .flow-topic-title and remove !important

https://gerrit.wikimedia.org/r/177465

In T76598#808480, @Mattflaschen wrote:

Remaining part is to stop using !important here, since it isn't needed.

This is done. It's not used for anything related to topic titles.

It's still used in two places:

  • flow-input-compressed (two declarations)
  • flow-ui-tooltip (one declaration)

Neither have anything to do with topic titles, so I think this should be closed. If someone would like us to drop the remaining ones, that should be a separate bug.

Quiddity closed this task as Resolved.Jan 28 2015, 7:42 PM
Quiddity set Security to None.