Page MenuHomePhabricator

Figure out how to upgrade to elastica in Translate
Closed, ResolvedPublic

Description deprecates setFilter in favour of setPostFilter. I need to use filtering due to facets. There is no obvious way to handle this with if-else to be compatible with both version without causing flood of deprecation notices.

Possible options are contacting upstream, just coordinating simultaneous update with WMF, having a version number provider in Elastica.

Event Timeline

Nikerabbit raised the priority of this task from to Medium.
Nikerabbit updated the task description. (Show Details)
Nikerabbit changed Security from none to None.

Do they add a setPostFiltet? If so you can test for it and call it only if

Nikerabbit changed the task status from Open to Stalled.Jan 28 2015, 5:50 PM

Thanks for picking this up. Let's wait and see how they respond.