Page MenuHomePhabricator
Create Task
Maniphest T76727

Figure out how to upgrade to elastica 1.3.4.0 in Translate
Closed, ResolvedPublic
Actions

Description

1.3.4.0 deprecates setFilter in favour of setPostFilter. I need to use filtering due to facets. There is no obvious way to handle this with if-else to be compatible with both version without causing flood of deprecation notices.

Possible options are contacting upstream, just coordinating simultaneous update with WMF, having a version number provider in Elastica.

Related Objects

Event Timeline

Nikerabbit created this task.Dec 4 2014, 4:00 PM
Nikerabbit raised the priority of this task from to Medium.
Nikerabbit updated the task description. (Show Details)
Nikerabbit added a project: MediaWiki-extensions-Translate.
Nikerabbit changed Security from none to None.
Nikerabbit added subscribers: Nikerabbit, • demon, • Manybubbles.
Nikerabbit moved this task from Backlog to translation aids on the MediaWiki-extensions-Translate board.Jan 28 2015, 5:09 AM
• Manybubbles added a comment.Jan 28 2015, 7:25 AM

Do they add a setPostFiltet? If so you can test for it and call it only if
defined.

Nikerabbit added a comment.Jan 28 2015, 3:22 PM

Nope. Compare: https://github.com/ruflin/Elastica/blob/v1.3.0.0/lib/Elastica/Query.php#L413 and https://github.com/ruflin/Elastica/blob/v1.3.4.0/lib/Elastica/Query.php#L419

• Manybubbles added a comment.Jan 28 2015, 5:13 PM

Lame lame lame.

• Manybubbles added a comment.Jan 28 2015, 5:18 PM

https://github.com/ruflin/Elastica/issues/763

Nikerabbit changed the task status from Open to Stalled.Jan 28 2015, 5:50 PM

Thanks for picking this up. Let's wait and see how they respond.

ruflin subscribed.Jan 28 2015, 7:31 PM

@Nikerabbit @Manybubbles See my comment on the issue.

• demon unsubscribed.Aug 19 2015, 3:56 PM
Nikerabbit closed this task as Resolved.Oct 1 2015, 7:34 AM
Nikerabbit claimed this task.

Closing per T108959: Deprecated: Elastica\Query::setFilter() is deprecated.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL