Flow Notifications for New Topics are not visible in the flyout
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Quiddity
	Dec 9 2014, 3:50 AM

Description

With one account, I made a new post at https://www.mediawiki.org/wiki/Talk:Sandbox
With a second account that is watchlisting that page, I received an updated Red Badge (1), and the flyout said "Message (1)", but the item itself was not visible in the flyout.

Flow_missing_notification_error_screenshot (1×1 px, 318 KB)

When I close the flyout, and then re-open it again, it is displaying the "Alerts" tab. So it is somehow marking the topic as visited/read. (possibly a separate issue, or just interconnected).

(reported by Hhhippo at https://www.mediawiki.org/wiki/Topic:S7lij74qkba2lq3r )

Details

	Subject	Repo	Branch	Lines +/-
	Fix new topic notifications not displaying	mediawiki/extensions/Flow	wmf/1.25wmf11	+12 -3
	Fix new topic notifications not displaying	mediawiki/extensions/Flow	master	+12 -3

Customize query in gerrit

Related Objects

Mentioned In: rMEXT021a4bfc8d2c: Updated mediawiki/extensions Project: mediawiki/extensions/Flow…
rEFLWfc8448091ef2: Fix new topic notifications not displaying
rEFLWa4df9419e2dc: Fix new topic notifications not displaying

Event Timeline

Quiddity created this task.Dec 9 2014, 3:50 AM

Quiddity raised the priority of this task from to High.

Quiddity updated the task description. (Show Details)

Quiddity added projects: Notifications, StructuredDiscussions, Collaboration-Team-Triage.

Quiddity changed Security from none to None.

Quiddity subscribed.

• Mattflaschen-WMF raised the priority of this task from High to Unbreak Now!.Dec 9 2014, 4:10 AM

• Mattflaschen-WMF subscribed.

• Mattflaschen-WMF claimed this task.Dec 9 2014, 4:17 AM

The actual notification itself is missing:

JSON:

"292": {
    "id": "292",
    "type": "flow-new-topic",
    "category": "flow-discussion",
    "timestamp": {
        "utcunix": "1418100472",
        "unix": "1418100472",
        "mw": "20141209044752",
        "date": "Today"
    },
    "title": {
        "full": "Talk:Sandbox",
        "namespace": "Talk",
        "namespace-key": 1,
        "text": "Sandbox"
    },
    "agent": {
        "id": 0,
        "name": "10.0.2.2"
    },
    "read": "20141209045022",
    "targetpage": "",
    "*": ""
}

Note the '*' field, where it should be.

XML:

<notification id="292" type="flow-new-topic" category="flow-discussion" read="20141209045022" targetpage="" xml:space="preserve" />

The notification element should have children.

• Spage moved this task from Untriaged to Team discussion on the Collaboration-Team-Triage board.Dec 9 2014, 6:47 PM

• Mattflaschen-WMF moved this task from Team discussion to Sprint O (ends Jan 27) on the Collaboration-Team-Triage board.Dec 9 2014, 6:47 PM

• Spage moved this task from Sprint O (ends Jan 27) to In Development on the Collaboration-Team-Triage board.Dec 9 2014, 6:47 PM

Change 178588 had a related patch set uploaded (by Mattflaschen):
Fix new topic notifications not displaying

https://gerrit.wikimedia.org/r/178588

Patch-For-Review

When I close the flyout, and then re-open it again, it is displaying the "Alerts" tab. So it is somehow marking the topic as visited/read. (possibly a separate issue, or just interconnected).

It turns out that it deliberately marks broken (unformattable) events as read so we don't continually show a red 1 for an event they can't currently see.

• Mattflaschen-WMF moved this task from In Development to Code Review on the Collaboration-Team-Triage board.Dec 9 2014, 8:09 PM

Change 178588 merged by jenkins-bot:
Fix new topic notifications not displaying

https://gerrit.wikimedia.org/r/178588

• Elitre subscribed.Dec 10 2014, 8:36 PM

• Mattflaschen-WMF mentioned this in rEFLWa4df9419e2dc: Fix new topic notifications not displaying.Dec 10 2014, 8:39 PM

Change 179013 had a related patch set uploaded (by Mattflaschen):
Fix new topic notifications not displaying

https://gerrit.wikimedia.org/r/179013

Patch-For-Review

Change 179013 merged by jenkins-bot:
Fix new topic notifications not displaying

https://gerrit.wikimedia.org/r/179013

• Mattflaschen-WMF mentioned this in rEFLWfc8448091ef2: Fix new topic notifications not displaying.Dec 11 2014, 12:07 AM

Liuxinyu970226 subscribed.Dec 12 2014, 3:32 AM