Page MenuHomePhabricator
Create Task
Maniphest T78041

Vertical alignment of text in the search-and-replace field is off in VisualEditor
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

See screenshot:

Screen_Shot_2014-12-09_at_11.51.55.png (197×1 px, 35 KB)

Details

SubjectRepoBranchLines +/-
ButtonGroupWidget: Remove weird margin-bottom: -1px; from theme stylesoojs/uimaster+0 -2
TextInputWidget: Set vertical-align: middle, like buttonsoojs/uimaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Dec 9 2014, 8:11 PM
Jdforrester-WMF raised the priority of this task from to Needs Triage.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF changed Security from none to None.
Jdforrester-WMF subscribed.
Jdforrester-WMF added projects: VisualEditor, OOUI, VisualEditor-MediaWiki.Dec 9 2014, 8:20 PM
Jdforrester-WMF triaged this task as High priority.Dec 9 2014, 8:33 PM
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Dec 9 2014, 8:37 PM
Esanders subscribed.Dec 10 2014, 6:40 PM

We'd need to upstream this functionality into OOUI, as the input widget padding varies from skin to skin.

Jdforrester-WMF assigned this task to matmarex.Dec 11 2014, 10:22 PM
gerritbot added a project: Patch-For-Review.Dec 11 2014, 11:11 PM

Change 179339 had a related patch set uploaded (by Bartosz Dziewoński):
TextInputWidget: Set vertical-align: middle, like buttons

https://gerrit.wikimedia.org/r/179339

Patch-For-Review

matmarex added a comment.Dec 11 2014, 11:13 PM

I am not sure if the patch fixes the issue here, because I've somehow broken all the styles for the search-and-replace "pulldown" locally. Let's retest this after pulling all recent fixes through.

Jdforrester-WMF added a comment.Dec 12 2014, 1:20 AM

Above patch doesn't seem to fix the issue at hand:

Screen_Shot_2014-12-11_at_17.17.55.png (627×1 px, 79 KB)

Jdforrester-WMF added a comment.Dec 12 2014, 7:30 PM

Not fixed. I'm going to declare this not a blocker to switching.

gerritbot added a comment.Dec 12 2014, 7:36 PM

Change 179339 merged by jenkins-bot:
TextInputWidget: Set vertical-align: middle, like buttons

https://gerrit.wikimedia.org/r/179339

matmarex renamed this task from Vertical alignment of text in the search-and-replace field is off in VisualEditor when using the OOjs UI MediaWiki theme to Vertical alignment of text in the search-and-replace field is off in VisualEditor.Dec 12 2014, 8:35 PM
matmarex removed a project: Patch-For-Review.

This also affects the Apex theme.

matmarex added a project: Patch-For-Review.Dec 12 2014, 8:40 PM

https://gerrit.wikimedia.org/r/#/c/179545/

matmarex moved this task from Backlog to Next-up on the OOUI board.Dec 14 2014, 7:18 PM
Jdforrester-WMF moved this task from TR6: Visual diffs to FY 18-19 Q3/Q4 on the VisualEditor board.Dec 16 2014, 8:44 PM
gerritbot added a comment.Dec 16 2014, 8:47 PM

Change 179545 merged by jenkins-bot:
ButtonGroupWidget: Remove weird margin-bottom: -1px; from theme styles

https://gerrit.wikimedia.org/r/179545

matmarex moved this task from Next-up to Doing on the OOUI board.Dec 16 2014, 10:05 PM
Jdforrester-WMF closed this task as Resolved.Dec 18 2014, 9:12 PM
Jdforrester-WMF added a project: WMF-deploy-2014-12-17_(1.25wmf13).
Jdforrester-WMF removed a project: Patch-For-Review.Jan 7 2015, 9:25 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Jan 23 2015, 11:32 PM
Jdforrester-WMF edited a custom field.Feb 2 2015, 7:52 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Feb 3 2015, 5:02 PM
matmarex mentioned this in rGOJUa9475fe3780e: TextInputWidget: Set vertical-align: middle, like buttons.Mar 3 2015, 7:49 PM
matmarex mentioned this in rGOJU1a65d62f753f: ButtonGroupWidget: Remove weird margin-bottom: -1px; from theme styles.
Jdforrester-WMF moved this task from Doing to Reviewing on the OOUI board.Mar 26 2015, 8:59 PM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits