Maniphest T78736

Inheriting color and background color for mw-ui-input is not really desired behavior
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Mattflaschen-WMF
	Dec 17 2014, 12:30 AM

Tags

Referenced Files

	F30362: pasted_file
	Jan 20 2015, 10:39 PM

Subscribers

• Mattflaschen-WMF

Description

There's nowhere we rely on this behavior (with a non-white background color), but it can make it harder for on-wiki users (@Jackmcbarn mentioned this to me).

Before, we were setting color but not background-color (setting one but not the other is always wrong, since it can conflict with user or system styles). In @matmarex's commit that fixed this (https://gerrit.wikimedia.org/r/#/c/168261/) he mentioned we might want to just remove it. The alternative is to set them to something reasonable like black (or dark grey) text and white background.

See T74192: MediaWiki UI: Unreadable text with dark system settings in .mw-ui-input

Details

	Subject	Repo	Branch	Lines +/-
	mediawiki.ui: Remove color and background-color 'inherit' from inputs	mediawiki/core	master	+0 -3

Customize query in gerrit

Related Objects

Mentioned In: T148457: Mediawiki UI: Inputs: Explicitly define text color
rMW9e8afeb36a87: mediawiki.ui: Remove color and background-color 'inherit' from inputs
Mentioned Here: T74192: MediaWiki UI: Unreadable text with dark system settings in .mw-ui-input

Event Timeline

• Mattflaschen-WMF created this task.Dec 17 2014, 12:30 AM

• Mattflaschen-WMF raised the priority of this task from to Needs Triage.

• Mattflaschen-WMF triaged this task as Medium priority.

• Mattflaschen-WMF updated the task description. (Show Details)

• Mattflaschen-WMF added a project: UI-Standardization.

• Mattflaschen-WMF changed Security from none to None.

• Mattflaschen-WMF added subscribers: • Mattflaschen-WMF, Jackmcbarn, matmarex.

This is causing actual issues, like in the signup form:

pasted_file (548×325 px, 40 KB)

The CAPTCHA field background is greyish instead of white.

Change 186094 had a related patch set uploaded (by Bartosz Dziewoński):
Remove color: inherit; background-color: inherit; from mediawiki.ui inputs

https://gerrit.wikimedia.org/r/186094

Patch-For-Review

Change 186094 merged by jenkins-bot:
mediawiki.ui: Remove color and background-color 'inherit' from inputs

https://gerrit.wikimedia.org/r/186094

Krinkle mentioned this in rMW9e8afeb36a87: mediawiki.ui: Remove color and background-color 'inherit' from inputs.Jan 24 2015, 7:07 AM

matmarex closed this task as Resolved.Jan 24 2015, 7:53 AM

matmarex claimed this task.

matmarex edited projects, added MediaWiki-General, MediaWiki-User-login-and-signup; removed Patch-For-Review.

matmarex removed a subscriber: gerritbot.

• Prtksxna mentioned this in T148457: Mediawiki UI: Inputs: Explicitly define text color.Oct 17 2016, 7:01 PM