Page MenuHomePhabricator

Inheriting color and background color for mw-ui-input is not really desired behavior
Closed, ResolvedPublic

Description

There's nowhere we rely on this behavior (with a non-white background color), but it can make it harder for on-wiki users (@Jackmcbarn mentioned this to me).

Before, we were setting color but not background-color (setting one but not the other is always wrong, since it can conflict with user or system styles). In @matmarex's commit that fixed this (https://gerrit.wikimedia.org/r/#/c/168261/) he mentioned we might want to just remove it. The alternative is to set them to something reasonable like black (or dark grey) text and white background.

See T74192: MediaWiki UI: Unreadable text with dark system settings in .mw-ui-input

Details

Related Gerrit Patches:

Event Timeline

Mattflaschen-WMF raised the priority of this task from to Needs Triage.
Mattflaschen-WMF triaged this task as Medium priority.
Mattflaschen-WMF updated the task description. (Show Details)
Mattflaschen-WMF changed Security from none to None.

This is causing actual issues, like in the signup form:

The CAPTCHA field background is greyish instead of white.

gerritbot added a subscriber: gerritbot.

Change 186094 had a related patch set uploaded (by Bartosz Dziewoński):
Remove color: inherit; background-color: inherit; from mediawiki.ui inputs

https://gerrit.wikimedia.org/r/186094

Patch-For-Review

Change 186094 merged by jenkins-bot:
mediawiki.ui: Remove color and background-color 'inherit' from inputs

https://gerrit.wikimedia.org/r/186094

matmarex closed this task as Resolved.Jan 24 2015, 7:53 AM
matmarex claimed this task.
matmarex removed a subscriber: gerritbot.