Page MenuHomePhabricator

Icon containers should always be the same size so we can use background-size: contain
Closed, ResolvedPublic

Description

In the toolbar most icons are 1.5em x 1.5em which is 24px x 24px in the default implementation. In cases where icons need more padding we have set them to 2em x 2em instead of adding 0.25em padding.

If icons were always 1.5em x 1.5em we could set background-size to contain and then users could change their base font size to scale the whole interface, including icon sizes. Currently setting background-size to contain makes some icons larger than others.

Event Timeline

Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: OOUI.
Esanders changed Security from none to None.
Esanders subscribed.
Esanders renamed this task from Icon containers should always be the same size so we can use background-size: cover to Icon containers should always be the same size so we can use background-size: contain.Dec 23 2014, 7:28 PM
Esanders updated the task description. (Show Details)

Change 181617 had a related patch set uploaded (by Esanders):
Make icon and indicator container sizes consistent

https://gerrit.wikimedia.org/r/181617

Patch-For-Review

Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF moved this task from Backlog to Doing on the OOUI board.

Change 181617 merged by jenkins-bot:
Make icon and indicator container sizes consistent

https://gerrit.wikimedia.org/r/181617

en.wiki:
.oo-ui-popupToolGroup-handle .oo-ui-iconElement-icon {
top: 0;
width: 2em;
height: 2em;
opacity: 0.8;
}

beta:
.oo-ui-popupToolGroup-handle .oo-ui-iconElement-icon {
top: 0;
left: 0.25em;
width: 1.5em;
height: 1.5em;
margin: 0.25em;