[Unplanned] ContentTranslation cookie sends expires in seconds instead of days
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Amire80
	Dec 29 2014, 9:50 PM

Description

The ContentTranslation cookie sends 'expires' as a number of seconds (ext.cx.source.selector.js, line 743.) If I understand jquery.cookie's documentation correctly, it's supposed to be set either as a number of days or as a 'date' object.

Details

	Subject	Repo	Branch	Lines +/-
	Use a date object for cookie expiration	mediawiki/extensions/ContentTranslation	master	+7 -4

Customize query in gerrit

Related Objects

Mentioned In: rMEXT93ed1de9b632: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation…
rECTXaaef0e39ea5f: Use a date object for cookie expiration

Event Timeline

Amire80 created this task.Dec 29 2014, 9:50 PM

Amire80 raised the priority of this task from to High.

Amire80 updated the task description. (Show Details)

Amire80 added projects: ContentTranslation, ContentTranslation-Release3.

Amire80 subscribed.

Change 182114 had a related patch set uploaded (by Amire80):
Use a date object for cookie expiration

https://gerrit.wikimedia.org/r/182114

Patch-For-Review

Amire80 renamed this task from ContentTranslation cookie sends expires in seconds instead of days to [Unplanned] ContentTranslation cookie sends expires in seconds instead of days.Dec 29 2014, 11:46 PM

Amire80 claimed this task.

Amire80 added a project: LE-Sprint-81.

Amire80 set Security to None.

Amire80 moved this task from Backlog to In Review on the LE-Sprint-81 board.

santhosh renamed this task from [Unplanned] ContentTranslation cookie sends expires in seconds instead of days to ContentTranslation cookie sends expires in seconds instead of days.Dec 30 2014, 3:48 AM

Change 182114 merged by jenkins-bot:
Use a date object for cookie expiration

https://gerrit.wikimedia.org/r/182114

santhosh closed this task as Resolved.Dec 30 2014, 3:49 AM

santhosh subscribed.

santhosh mentioned this in rECTXaaef0e39ea5f: Use a date object for cookie expiration.Dec 30 2014, 3:49 AM

Arrbee moved this task from In Review to Done on the LE-Sprint-81 board.Dec 30 2014, 7:00 AM