Page MenuHomePhabricator
Create Task
Maniphest T85803

server admin log should include year in date (again)
Closed, ResolvedPublic
Actions

Description

The server admin log (SAL) should include the year in the date. This was once done in 2012, see e.g. https://wikitech.wikimedia.org/wiki/Nova_Resource:Wikidata-dev/SAL .

Details

SubjectRepoBranchLines +/-
up version to 1.7.7 - add year to logsoperations/debs/adminbotmaster+6 -0
added year into logging, made pep8 and pyflakes happyoperations/debs/adminbotmaster+18 -18
Customize query in gerrit

Related Objects
Search...

Event Timeline

JanZerebecki created this task.Jan 5 2015, 3:27 PM
JanZerebecki raised the priority of this task from to Needs Triage.
JanZerebecki updated the task description. (Show Details)
JanZerebecki subscribed.
Aklapper added a project: ops-requests.Jan 5 2015, 5:46 PM
Aklapper set Security to None.
• chasemp triaged this task as Low priority.Jan 6 2015, 11:03 PM
• chasemp edited projects, added acl*sre-team; removed ops-requests.
Krenair added a project: good first task.May 30 2015, 10:32 PM
Krenair subscribed.

Looks easy for anyone with a basic knowledge of Python: https://git.wikimedia.org/blob/operations%2Fdebs%2Fadminbot.git/579ea5abfc7b4b70d7ed82fa6b45956dd30090e9/adminlog.py#L34

Elee subscribed.Jul 6 2015, 3:44 PM

Currently, the log goes == Month 01 ==.

Would the year go after or before? As in: == Month 01 2015 == or == 2015 Month 01 ==?

Restricted Application added a subscriber: Matanya. · View Herald TranscriptJul 6 2015, 3:44 PM
JanZerebecki added a comment.Jul 6 2015, 3:49 PM

The later: == 2015 July 06 ==

Krenair added a comment.Jul 6 2015, 3:50 PM

YMD. MDY is silly

RobH subscribed.Jul 6 2015, 4:02 PM

I hate the entire date format, as I like YYYY-MM-DD, (reference: https://xkcd.com/1179/ ).

That being said, the old use had July 19th 2012.

I suppose it should put in the trailing 19th, 23rd, etc... to match what was initially done; unless that bit of code is unusually tricky.

So the old use was: July 19th 2012

For the proposed two options: == Month 01 2015 == matches the old use the closest.

gerritbot subscribed.Jul 6 2015, 4:20 PM

Change 223046 had a related patch set uploaded (by Elee):
added year into logging

https://gerrit.wikimedia.org/r/223046

gerritbot added a project: Patch-For-Review.Jul 6 2015, 4:20 PM
Negative24 subscribed.Jul 6 2015, 4:23 PM
Elee added a comment.Jul 8 2015, 12:38 AM

Sorry for the delay, everything should be happy now.

Elee claimed this task.Jul 8 2015, 12:38 AM
gerritbot added a comment.Jul 8 2015, 2:50 PM

Change 223046 merged by Dzahn:
added year into logging, made pep8 and pyflakes happy

https://gerrit.wikimedia.org/r/223046

JanZerebecki added a subtask: T105169: build new .deb for adminbot/morebots, install on toollabs.Jul 8 2015, 3:26 PM
gerritbot added a comment.Jul 8 2015, 4:17 PM

Change 223575 had a related patch set uploaded (by Dzahn):
up version to 1.7.7 - add year to logs

https://gerrit.wikimedia.org/r/223575

gerritbot added a comment.Jul 8 2015, 4:18 PM

Change 223575 merged by jenkins-bot:
up version to 1.7.7 - add year to logs

https://gerrit.wikimedia.org/r/223575

Elee mentioned this in rODAC9d742103ac81: added year into logging, made pep8 and pyflakes happy.Jul 8 2015, 4:25 PM
Dzahn mentioned this in rODACc3ea5ba05a5c: up version to 1.7.7 - add year to logs.Jul 8 2015, 4:25 PM
Dzahn closed subtask T105169: build new .deb for adminbot/morebots, install on toollabs as Resolved.Jul 10 2015, 1:54 AM
JanZerebecki added a comment.Jul 10 2015, 4:47 PM

As seen in the backtrace https://phabricator.wikimedia.org/T105169#1444010 this needs to also work with the old log entries that have less than 5 space separated parts in headings.

Aklapper added a comment.Oct 31 2015, 12:32 PM

@Elee: Any news here? Are you still working on this (as you're set as assignee)?

Aklapper added a comment.Nov 29 2015, 6:07 PM

@Elee: Any news here? Are you still working on this (as you're set as assignee)?

Aklapper added a comment.Dec 30 2015, 12:49 PM

@Elee: Any news here? Are you still working on this (as you're set as assignee)?

Aklapper removed Elee as the assignee of this task.Feb 27 2016, 9:29 PM
Aklapper removed a project: Patch-For-Review.

@Elee: I am resetting the assignee of this task because there have been no signs of progress lately (please correct me if I'm wrong).
Resetting the assignee avoids the impression that somebody is already working on fixing this task and it also allows anybody else to potentially work towards fixing this task.
Please claim this task again when you plan to fix this task (via 'Assign / Claim' in the 'Actions' dropdown menu) - it would be very welcome!
Thanks for your understanding!

valhallasw closed this task as Resolved.Feb 27 2016, 10:04 PM
valhallasw claimed this task.
valhallasw subscribed.

The SAL has been using YYYY-MM-DD for a while now, so I think we can consider this resolved/.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits