Page MenuHomePhabricator

Ajax code refactoring
Closed, ResolvedPublic

Description

Author: felipe.sanches

Description:
I've been doing some little refactoring to the current ajax code. Since it is
intended to grow significantly as new features get developed, I decided to
remove the search feature specific portions of code from ajax.js and put it on a
new AjaxSearch.js file.

It is intended to have a new javascript file and config variable for each new
ajax feature developed in order to allow feature-specific control. All of these
variables default to true in order to still allow the use of $wgUseAjax for
global control.

All ajax files should be created at skins/common/ajax directory.


Version: unspecified
Severity: enhancement

Details

Reference
bz6612

Related Objects

StatusSubtypeAssignedTask
Resolvedmatmarex
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:16 PM
bzimport set Reference to bz6612.
bzimport added a subscriber: Unknown Object (MLST).

felipe.sanches wrote:

patch that does this refactoring

Attached:

felipe.sanches wrote:

this bug is closely related to bug 6593.

ayg wrote:

It's not a bug, ergo it's an enhancement. Don't feel too bad if no one with
commit access is willing to look over a 300-line patch to make sure it's
bug-free and useful; it's only to be expected. I would suggest you try spelling
out the reasons your patch is useful, and then just forget about it and move on
to other things. There's really not enough manpower around here to allow all
patches to be reviewed, unfortunately.

Seems to have been cleaned up already.