InputWidgets should detect the internal .value property and the <input>'s .value property getting desynchronised and do something smart
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Jan 15 2015, 12:59 AM

Description

Splitting off from T71749.

InputWidgets should detect the internal .value property and the <input>'s .value property getting desynchronised and do something smart.

@eranroz's proposal is that we just re-synchronize in #getValue and Trevor and I like that. Let's do it.

Patch

getValueFix.diff649 BDownload

from T71749#745592 needs to be adapted for other InputWidgets.

	Subject	Repo	Branch	Lines +/-
	InputWidget: Resynchronize our internal .value with DOM .value in #getValue	oojs/ui	master	+12 -0

Mentioned In: rGOJU4a54b7ab5337: InputWidget: Resynchronize our internal .value with DOM .value in #getValue
T71749: VisualEditor: saveOptions.summary is not updated if the summary is inserted using a tool (InputWidget relies on 'change' events rather than checking the value)
Mentioned Here: T71749: VisualEditor: saveOptions.summary is not updated if the summary is inserted using a tool (InputWidget relies on 'change' events rather than checking the value)

matmarex claimed this task.

matmarex raised the priority of this task from to Needs Triage.

matmarex updated the task description. (Show Details)

matmarex added a project: OOUI.

matmarex triaged this task as High priority.Jan 15 2015, 1:31 AM

Change 185335 had a related patch set uploaded (by Bartosz Dziewoński):
InputWidget: Resynchronize our internal .value with DOM .value in #getValue

@eranroz, I tweaked the patch and submitted it, with you as the author. Please confirm that you're okay with me changes. :)

Change 185335 merged by jenkins-bot:
InputWidget: Resynchronize our internal .value with DOM .value in #getValue

Jdforrester-WMF lowered the priority of this task from High to Medium.

Jdforrester-WMF raised the priority of this task from Medium to High.

Jdforrester-WMF moved this task from Next-up to Doing on the OOUI board.

Jdforrester-WMF set Security to None.