Page MenuHomePhabricator

ve.init.mw.Target.prototype.saveErrorNewUser is evil
Closed, ResolvedPublic1 Story Points

Description

ve.init.mw.Target.prototype.saveErrorNewUser together with ve.init.mw.Target.prototype.saveFail works around T49395 by dynamically creating new mw.message messages. Fixing T49395 can't possibly be difficult enough to justify this travesty.

Event Timeline

matmarex created this task.Jan 20 2015, 7:05 AM
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added a subscriber: matmarex.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2015, 7:05 AM
Jdforrester-WMF triaged this task as Low priority.Jan 20 2015, 8:07 PM
Jdforrester-WMF raised the priority of this task from Low to Normal.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
matmarex renamed this task from ve.init.mw.ViewPageTarget.prototype.onSaveErrorNewUser is evil to ve.init.mw.Target.prototype.saveErrorNewUser is evil.Oct 6 2015, 4:57 PM
matmarex updated the task description. (Show Details)

Change 243957 had a related patch set uploaded (by Bartosz Dziewoński):
ve.init.mw.Target: Remove jqueryMsg hacks in #saveErrorNewUser

https://gerrit.wikimedia.org/r/243957

Change 243957 merged by jenkins-bot:
ve.init.mw.Target: Remove jqueryMsg hacks in #saveErrorNewUser

https://gerrit.wikimedia.org/r/243957