Page MenuHomePhabricator
Create Task
Maniphest T87219

ve.init.mw.Target.prototype.saveErrorNewUser is evil
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

ve.init.mw.Target.prototype.saveErrorNewUser together with ve.init.mw.Target.prototype.saveFail works around T49395 by dynamically creating new mw.message messages. Fixing T49395 can't possibly be difficult enough to justify this travesty.

Details

SubjectRepoBranchLines +/-
ve.init.mw.Target: Remove jqueryMsg hacks in #saveErrorNewUsermediawiki/extensions/VisualEditormaster+3 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Jan 20 2015, 7:05 AM
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added projects: VisualEditor, Technical-Debt.
matmarex subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2015, 7:05 AM
matmarex added a subtask: T49395: jqueryMsg can not parse wikilink with parameters in page name.Jan 20 2015, 7:10 AM
Jdforrester-WMF triaged this task as Low priority.Jan 20 2015, 8:07 PM
Jdforrester-WMF raised the priority of this task from Low to Medium.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
matmarex claimed this task.Oct 6 2015, 11:57 AM
matmarex closed subtask T49395: jqueryMsg can not parse wikilink with parameters in page name as Resolved.

Fixing T49395 indeed wasn't that bad.

matmarex renamed this task from ve.init.mw.ViewPageTarget.prototype.onSaveErrorNewUser is evil to ve.init.mw.Target.prototype.saveErrorNewUser is evil.Oct 6 2015, 4:57 PM
matmarex updated the task description. (Show Details)
gerritbot subscribed.Oct 6 2015, 5:04 PM

Change 243957 had a related patch set uploaded (by Bartosz Dziewoński):
ve.init.mw.Target: Remove jqueryMsg hacks in #saveErrorNewUser

https://gerrit.wikimedia.org/r/243957

gerritbot added a project: Patch-For-Review.Oct 6 2015, 5:04 PM
gerritbot added a comment.Oct 6 2015, 9:09 PM

Change 243957 merged by jenkins-bot:
ve.init.mw.Target: Remove jqueryMsg hacks in #saveErrorNewUser

https://gerrit.wikimedia.org/r/243957

matmarex mentioned this in rEVEDc684e2c6828d: ve.init.mw.Target: Remove jqueryMsg hacks in #saveErrorNewUser.Oct 6 2015, 9:11 PM
Jdforrester-WMF closed this task as Resolved.Oct 6 2015, 9:52 PM
Jdforrester-WMF edited projects, added VisualEditor-MediaWiki, MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)); removed Patch-For-Review.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Freezer to TR0: Interrupt on the VisualEditor board.Oct 21 2015, 10:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL