Page MenuHomePhabricator

"Delete row"/"Delete column" messages do not use the plural when multiple rows/columns are selected (but they do delete multiple rows/columns)
Closed, ResolvedPublic1 Story Points

Description

When multiple rows/columns are selected, the options to "Delete row" or "Delete column" do not change to "Delete rows"/"Delete columns", despite the fact that the actions do delete all selected rows/columns, and not just the "active" row or column. (IIRC, there actually once was a major table-editing program that did particularly delete only the active row/column and not all selected rows/columns, so this could be a point of confusion. Not completely sure about this.)

Event Timeline

Yair_rand raised the priority of this task from to Needs Triage.
Yair_rand updated the task description. (Show Details)
Yair_rand added a subscriber: Yair_rand.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2015, 2:02 PM
Jdforrester-WMF renamed this task from "Delete row"/"Delete column" are not pluralized when multiple rows/columns are selected to "Delete row"/"Delete column" messages are not pluralized when multiple rows/columns are selected (but they do delete multiple rows/columns).Jan 20 2015, 5:50 PM
Jdforrester-WMF triaged this task as Normal priority.
Jdforrester-WMF set Security to None.
Jdforrester-WMF renamed this task from "Delete row"/"Delete column" messages are not pluralized when multiple rows/columns are selected (but they do delete multiple rows/columns) to "Delete row"/"Delete column" messages do not use the plural when multiple rows/columns are selected (but they do delete multiple rows/columns).Jan 20 2015, 5:53 PM
Jdforrester-WMF raised the priority of this task from Normal to Needs Triage.
Jdforrester-WMF triaged this task as Normal priority.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.

Change 198738 had a related patch set uploaded (by Jforrester):
"Delete row"/"Delete column" messages now using the plural when multiple rows/columns are selected

https://gerrit.wikimedia.org/r/198738

Change 198738 merged by jenkins-bot:
Use plural grammar in table context for deleting multiple rows/columns

https://gerrit.wikimedia.org/r/198738

Verified the fix in Betalabs