Page MenuHomePhabricator
Create Task
Maniphest T87417

Get rid of unnecessary jQuery.html call in ve.dm.MWReferenceNode.static.toDomElements
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Suggested by Paul Irish.

Details

SubjectRepoBranchLines +/-
Use DOM methods instead of jQuery .html() in references DM codemediawiki/extensions/VisualEditormaster+14 -9
Customize query in gerrit

Related Objects

Event Timeline

ori created this task.Jan 23 2015, 7:33 AM
ori raised the priority of this task from to Needs Triage.
ori updated the task description. (Show Details)
ori added a project: VisualEditor-Performance.
ori added subscribers: ori, Krinkle, Catrope.
Restricted Application added a project: VisualEditor. · View Herald TranscriptJan 23 2015, 7:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ori renamed this task from Get rid of unnecessary jQuery.html call in ve.dm.InternalList.convertToData to Get rid of unnecessary jQuery.html call in ve.dm.InternalList.convertToData and ve.dm.MWReferenceNode.static.toDomElements.Jan 23 2015, 7:40 AM
ori set Security to None.
Jdforrester-WMF moved this task from Backlog to Next up on the VisualEditor-Performance board.Jan 23 2015, 6:40 PM
Jdforrester-WMF triaged this task as Medium priority.Jan 23 2015, 9:56 PM
Jdforrester-WMF moved this task from To Triage to Bug Fixes on the VisualEditor board.
Catrope added a comment.Jan 26 2015, 10:00 PM

The InternalList portion of this is a duplicate of T87418

Catrope renamed this task from Get rid of unnecessary jQuery.html call in ve.dm.InternalList.convertToData and ve.dm.MWReferenceNode.static.toDomElements to Get rid of unnecessary jQuery.html call in ve.dm.MWReferenceNode.static.toDomElements.Jan 26 2015, 10:00 PM
gerritbot added a project: Patch-For-Review.Jan 26 2015, 10:08 PM
gerritbot subscribed.

Change 186887 had a related patch set uploaded (by Catrope):
Use DOM methods instead of jQuery .html() in references DM code

https://gerrit.wikimedia.org/r/186887

Patch-For-Review

Catrope moved this task from Bug Fixes to Blocked on the VisualEditor board.Jan 26 2015, 10:09 PM
Catrope moved this task from Next up to Doing on the VisualEditor-Performance board.
Krenair assigned this task to Catrope.Jan 28 2015, 6:57 AM
Krenair subscribed.
Catrope moved this task from Doing to Done on the VisualEditor-Performance board.Jan 28 2015, 6:51 PM
gerritbot added a comment.Jan 28 2015, 11:38 PM

Change 186887 merged by jenkins-bot:
Use DOM methods instead of jQuery .html() in references DM code

https://gerrit.wikimedia.org/r/186887

Catrope mentioned this in rEVEDa10fe01f8ba3: Use DOM methods instead of jQuery .html() in references DM code.Jan 28 2015, 11:38 PM
Krenair closed this task as Resolved.Jan 29 2015, 11:07 PM

That was merged

Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Jan 29 2015, 11:08 PM
Jdforrester-WMF added a project: WMF-deploy-2015-02-04_(1.25wmf16).
Jdforrester-WMF subscribed.
Jdforrester-WMF removed a project: Patch-For-Review.Jan 30 2015, 6:22 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 9 2015, 6:04 PM
Jdforrester-WMF edited a custom field.Mar 9 2015, 6:10 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 9 2015, 6:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL