Page MenuHomePhabricator

Location template disregarded in collapsed mobile sections
Open, LowPublic

Description

Bug reported on https://commons.wikimedia.org/w/index.php?title=Commons:Forum&oldid=148750403#Fehlerhafte_Darstellung_der_Beschreibung_auf_Smartphones:

Location template is shown in file descriptions although it should be hidden in the collapsed section "summary".
See screenshot https://commons.wikimedia.org/wiki/File:Location_layout_bug.png

Event Timeline

Thgoiter created this task.Feb 2 2015, 8:56 PM
Thgoiter raised the priority of this task from to Needs Triage.
Thgoiter updated the task description. (Show Details)
Thgoiter added a project: Readers-Web-Backlog.
Thgoiter added a subscriber: Thgoiter.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2015, 8:56 PM
dschwen added a subscriber: dschwen.Feb 2 2015, 9:34 PM

{{Location}} is a separate template that inserts a box below the {{Information}} template. We use a border-collapse trick to make it look like the location row is part of the information table. Obviously this template is not parsed and added to the collapsible table that is generated from the information template contents.

Is there something we could do to improve the location template? Or does this need a severside change to process it along with the information template?

I'd think that assigning the appropriate classes to the rows should make then get picked up by the mobile site code automatically...

KLans_WMF triaged this task as Low priority.Mar 13 2015, 8:31 PM
KLans_WMF set Security to None.

In order for the location template to be under the summary heading it should reside in the same div as the previous table (Information template). Right now we (MF) just take the heading and make the next div collapsible. We ignore anything after it until the next heading.

DannyH added a subscriber: DannyH.Feb 4 2016, 6:11 PM

This is outside the scope for Community Tech, I think it's more appropriate for Mobile.

I talked to Jon; he thinks it's a task for Community Engagement.

Jdlrobson renamed this task from Location template disregarded in collapsed sections to Location template disregarded in collapsed mobile sections.May 4 2018, 6:53 PM