Page MenuHomePhabricator

Use POST for rollback
Closed, DuplicatePublic

Description

Currently for rollback a GET request is used. It would be better to use a POST request because "requests using GET should only retrieve data and should have no other effect." ( https://en.wikipedia.org/wiki/GET_(HTTP) )

Event Timeline

Fomafix raised the priority of this task from to Low.
Fomafix updated the task description. (Show Details)
Fomafix added a subscriber: Fomafix.

I think we originally went with GET in part so you could mass-revert by middle-clicking or control-clicking a bunch of links in a list and not have to go through and confirm each one.

If the UI is fixed up some you can revert 'in place', then API can use a POST without actually needing to open separate pages, in theory... Anyway consider the user experience before changing this. :)

A GET to allow middle-clicking is a comprehensible UI argument. But the normal click can changed to a POST by JavaScript without changing the UI.