Declare conditional dependency on WikimediaEvents, and don't try to use schema.Edit unless it's present
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	• brooke
	Feb 5 2015, 10:41 AM

Description

On opening VisualEditor on a local MediaWiki-Vagrant setup:

"Error: Unknown dependency: schema.Edit" Error: Unknown dependency: schema.Edit
Stack trace:
sortDependencies:156:1
resolve:158:14
mw.loader</<.using:169:189
handleTrackedEvent:1:310
mw.trackSubscribe/<:154:53
jQuery.Callbacks/fire:45:106
jQuery.Callbacks/self.fireWith:46:431
jQuery.Callbacks/self.fire:46:474
mw.track:153:818
:677:426
ve.trackSubscribe/<:1:409
jQuery.Callbacks/fire:45:106
jQuery.Callbacks/self.add:45:664
ve.trackSubscribe:1:285
ve.trackSubscribeAll:1:500
:676:95
:675:165
runScript:161:153
execute/</checkCssHandles:161:638
execute/</cssHandle/<:161:768
jQuery.Callbacks/fire:45:106
jQuery.Callbacks/self.fireWith:46:431
jQuery.Callbacks/self.fire:46:474
addEmbeddedCSS:156:531
addEmbeddedCSS/<:156:1
load.php:150

(long RL URLs trimmed)

and

"VisualEditor failed to load: Error: Module ext.visualEditor.mediawiki has failed dependencies"

Details

	Subject	Repo	Branch	Lines +/-
	Don't try to route any events into schema.Edit if it's not actually installed	mediawiki/extensions/VisualEditor	master	+5 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		nshahquinn-wmf	T88698 MobileFrontend vagrant role forces EventLogging on, breaks VisualEditor
		Resolved		Krenair	T88667 Declare conditional dependency on WikimediaEvents, and don't try to use schema.Edit unless it's present

Event Timeline

• brooke created this task.Feb 5 2015, 10:41 AM

• brooke raised the priority of this task from to Needs Triage.

• brooke updated the task description. (Show Details)

• brooke added projects: MediaWiki-Vagrant, VisualEditor.

• brooke subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 5 2015, 10:41 AM

• brooke updated the task description. (Show Details)Feb 5 2015, 10:43 AM

• brooke set Security to None.

You need to load WikimediaEvents if you've got EventLogging installed for VisualEditor to work.

Interesting, something else must be pulling it in as a dependency...

puppet/modules/role/manifests/mobilefrontend.pp: include ::role::eventlogging

Culprit found. :)

Is there any way we can have a cleaner failure mode here, such as detecting that this other extension that's also needed isn't present and disabling the eventlogging when it won't work?

• brooke added a parent task: T88698: MobileFrontend vagrant role forces EventLogging on, breaks VisualEditor.Feb 5 2015, 5:27 PM

Jdforrester-WMF renamed this task from VisualEditor on Vagrant gives "Error: Unknown dependency: schema.Edit" in JS console to Declare conditional dependency on WikimediaEvents, and don't try to use schema.Edit unless it's present.Feb 5 2015, 5:54 PM

Jdforrester-WMF triaged this task as Medium priority.

Jdforrester-WMF added a project: VisualEditor-MediaWiki.

Jdforrester-WMF moved this task from To Triage to Planned Maintenance on the VisualEditor board.Feb 5 2015, 5:58 PM

Krenair subscribed.Feb 5 2015, 10:17 PM

Change 192049 had a related patch set uploaded (by Alex Monk):
Don't try to route any events into schema.Edit if it's not actually installed

https://gerrit.wikimedia.org/r/192049

Patch-For-Review

Krenair claimed this task.Feb 21 2015, 2:45 AM

Change 192049 merged by jenkins-bot:
Don't try to route any events into schema.Edit if it's not actually installed

https://gerrit.wikimedia.org/r/192049

Krenair mentioned this in rEVEDc6dbdc92ea0f: Don't try to route any events into schema.Edit if it's not actually installed.Feb 21 2015, 3:30 AM

Jdforrester-WMF closed this task as Resolved.Feb 21 2015, 7:45 PM

Jdforrester-WMF added a project: WMF-deploy-2015-02-25_(1.25wmf19).

Jdforrester-WMF moved this task from Planned Maintenance to FY 18-19 Q3/Q4 on the VisualEditor board.Feb 21 2015, 7:53 PM

bd808 moved this task from Backlog to Done on the MediaWiki-Vagrant board.Feb 26 2015, 12:50 AM

Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 9 2015, 6:04 PM

Jdforrester-WMF edited a custom field.Mar 9 2015, 6:09 PM

Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 9 2015, 6:13 PM

Declare conditional dependency on WikimediaEvents, and don't try to use schema.Edit unless it's presentClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related ObjectsSearch...

Event Timeline

Declare conditional dependency on WikimediaEvents, and don't try to use schema.Edit unless it's present
Closed, ResolvedPublic1 Estimated Story Points
Actions

Related Objects
Search...