Page MenuHomePhabricator
Create Task
Maniphest T88764

[Regression] Media Settings - Infinite loop when an image is inserted
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Type 'tussen haerlem' into Media Settings box - Network tab will display endless amount of requests.

Details

SubjectRepoBranchLines +/-
Update VisualEditor submodulemediawiki/corewmf/1.25wmf16+1 -1
Refactor MWMediaSearchWidget to use a queue and providersmediawiki/extensions/VisualEditorwmf/1.25wmf16+818 -274
Refactor MWMediaSearchWidget to use a queue and providersmediawiki/extensions/VisualEditormaster+818 -274
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Feb 6 2015, 12:41 AM
Etonkovidova assigned this task to Mooeypoo.
Etonkovidova raised the priority of this task from to Unbreak Now!.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added a project: VisualEditor.
Etonkovidova subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2015, 12:41 AM
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.Feb 6 2015, 12:42 AM
gerritbot added a project: Patch-For-Review.Feb 6 2015, 6:37 PM
gerritbot subscribed.

Change 188725 had a related patch set uploaded (by Mooeypoo):
Refactor MWMediaSearchWidget to use a queue and providers

https://gerrit.wikimedia.org/r/188725

Patch-For-Review

gerritbot added a comment.Feb 7 2015, 1:15 AM

Change 188725 merged by jenkins-bot:
Refactor MWMediaSearchWidget to use a queue and providers

https://gerrit.wikimedia.org/r/188725

Mooeypoo mentioned this in rEVEDaa9eb9545524: Refactor MWMediaSearchWidget to use a queue and providers.Feb 7 2015, 1:15 AM
Etonkovidova added a comment.Feb 7 2015, 1:34 AM

Betalabs looks good.
Testing notes:

  • check for a search with many search results, e.g. 'lilac', 'cow'
  • check for a search with few results - 'After Cornelis Cornelisz. van Haarlem 001.jpg' returns two results.
Jdforrester-WMF renamed this task from Media Settings - Infinite loop when an image is inserted to [Regression] Media Settings - Infinite loop when an image is inserted.Feb 9 2015, 6:28 PM
Jdforrester-WMF edited projects, added VisualEditor-MediaWiki-Media, WMF-deploy-2015-02-11_(1.25wmf17), WMF-deploy-2015-02-04_(1.25wmf16); removed Patch-For-Review.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Feb 10 2015, 7:55 PM
Jdforrester-WMF edited a custom field.Feb 10 2015, 8:32 PM
gerritbot added a project: Patch-For-Review.Feb 10 2015, 11:12 PM

Change 189861 had a related patch set uploaded (by Alex Monk):
Refactor MWMediaSearchWidget to use a queue and providers

https://gerrit.wikimedia.org/r/189861

Patch-For-Review

gerritbot added a comment.Feb 10 2015, 11:18 PM

Change 189861 merged by jenkins-bot:
Refactor MWMediaSearchWidget to use a queue and providers

https://gerrit.wikimedia.org/r/189861

Krenair mentioned this in rEVEDadb1b37ba8ea: Refactor MWMediaSearchWidget to use a queue and providers.Feb 10 2015, 11:18 PM
gerritbot added a comment.Feb 10 2015, 11:43 PM

Change 189867 had a related patch set uploaded (by Alex Monk):
Update VisualEditor submodule

https://gerrit.wikimedia.org/r/189867

Patch-For-Review

gerritbot added a comment.Feb 11 2015, 12:21 AM

Change 189867 merged by jenkins-bot:
Update VisualEditor submodule

https://gerrit.wikimedia.org/r/189867

Krenair mentioned this in rMW36bd523aea92: Update VisualEditor submodule.Feb 11 2015, 12:21 AM
Krenair subscribed.Feb 11 2015, 12:33 AM

Deployed fix to 1.25wmf16 sites (i.e., not Wikipedias).

Etonkovidova added a comment.Feb 11 2015, 12:40 AM

Checked the fix in beta and in test2.

Etonkovidova added a project: Verified-in-Phase0.Feb 11 2015, 12:41 AM
Jdforrester-WMF closed this task as Resolved.Feb 11 2015, 5:53 PM
Jdforrester-WMF subscribed.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Feb 11 2015, 7:37 PM
Jdforrester-WMF removed a project: Patch-For-Review.Feb 19 2015, 9:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits