Page MenuHomePhabricator
Create Task
Maniphest T88977

TextInputWidget (autosize)‎ contains two textareas
Closed, ResolvedPublic
Actions

Description

This widget seems to have two actual <textarea> elements, which is undesirable for Accessibility and because it's just weird. :)

<div class="oo-ui-widget oo-ui-widget-enabled oo-ui-inputWidget oo-ui-textInputWidget-labelPosition-after oo-ui-textInputWidget-labelPosition-before oo-ui-textInputWidget" aria-disabled="false"><textarea tabindex="0" aria-disabled="false"></textarea><textarea tabindex="0" aria-disabled="false" class="oo-ui-element-hidden" rows="10" style="display: none; height: auto;"></textarea><span></span><span class="oo-ui-iconElement-icon"></span><span class="oo-ui-indicatorElement-indicator"></span><span class="oo-ui-labelElement-label"></span></div>

Details

SubjectRepoBranchLines +/-
TextInputWidget: Use aria-hidden for extra autosize textareaoojs/uimaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

TheDJ created this task.Feb 9 2015, 11:11 AM
TheDJ raised the priority of this task from to Needs Triage.
TheDJ updated the task description. (Show Details)
TheDJ added projects: OOUI, Accessibility.
TheDJ subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2015, 11:11 AM
• Prtksxna subscribed.Feb 9 2015, 2:46 PM

The widget should have two <textarea> elements only when its configured to autosize.

gerritbot added a project: Patch-For-Review.Feb 9 2015, 2:46 PM
gerritbot subscribed.

Change 189485 had a related patch set uploaded (by Prtksxna):
TextInputWidget: Use aria-hidden for extra autosize textarea

https://gerrit.wikimedia.org/r/189485

Patch-For-Review

gerritbot added a comment.Feb 9 2015, 4:05 PM

Change 189485 merged by jenkins-bot:
TextInputWidget: Use aria-hidden for extra autosize textarea

https://gerrit.wikimedia.org/r/189485

• Prtksxna closed this task as Resolved.Feb 9 2015, 4:12 PM
• Prtksxna claimed this task.
Jdforrester-WMF triaged this task as Medium priority.Feb 9 2015, 4:51 PM
Jdforrester-WMF added a project: OOjs-UI-next-release.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.7.0), WMF-deploy-2015-02-18_(1.25wmf18); removed OOjs-UI-next-release.Feb 12 2015, 12:28 AM
Jdforrester-WMF removed a project: Patch-For-Review.Feb 19 2015, 9:35 PM
• Prtksxna mentioned this in rGOJUf0f449856915: TextInputWidget: Use aria-hidden for extra autosize textarea.Mar 3 2015, 7:50 PM
Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Mar 26 2015, 9:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits