Page MenuHomePhabricator
Create Task
Maniphest T89367

TOC should be horizontally scrollable or items in it should wrap
Closed, ResolvedPublic
Actions

Description

Otherwise long lines overflow it. Please see the screenshot.

Screen_Shot_2015-02-12_at_1.36.33_PM.png (804×1 px, 111 KB)

Details

SubjectRepoBranchLines +/-
TOC: horizontal scrolling added for long wordsmediawiki/extensions/MobileFrontendmaster+4 -1
Customize query in gerrit

Related Objects

Event Timeline

• bmansurov created this task.Feb 12 2015, 6:37 PM
• bmansurov raised the priority of this task from to Needs Triage.
• bmansurov updated the task description. (Show Details)
• bmansurov added a project: Web-Team-Backlog.
• bmansurov subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2015, 6:37 PM
• bmansurov renamed this task from TOC should be horizontally scrollable to TOC should be horizontally scrollable or items in it should wrap.Feb 12 2015, 6:39 PM
• bmansurov set Security to None.
kaldari moved this task from Incoming to 2015-16 Q4 on the Web-Team-Backlog board.Feb 13 2015, 6:09 PM
Florian subscribed.Feb 13 2015, 11:17 PM
gerritbot added a project: Patch-For-Review.Feb 15 2015, 8:57 PM
gerritbot subscribed.

Change 190734 had a related patch set uploaded (by Sumit):
TOC: horizontal scrolling added for long words

https://gerrit.wikimedia.org/r/190734

Patch-For-Review

Sumit subscribed.Feb 15 2015, 8:58 PM

Was not sure regarding the view, presently added a scroll to TOC

Sumit added a comment.Feb 24 2015, 1:33 PM

Here's a screenshot, the text within <li> is small enough yet each <li>'s actual width is exceeding the container, which seems to be the problem. Because words wrap within <li>, they wrap after a little offset. Is this width of <li> the required behaviour?

Screenshot_from_2015-02-24_18:59:49.png (768×1 px, 121 KB)

Sumit added a comment.EditedFeb 24 2015, 1:56 PM

setting the width of containing toc-collapsible block(say to 90%), seems to work. Uploaded with that for now

• bmansurov closed this task as Resolved.Feb 25 2015, 5:49 PM
• bmansurov claimed this task.
gerritbot added a comment.Feb 25 2015, 5:50 PM

Change 190734 merged by jenkins-bot:
TOC: horizontal scrolling added for long words

https://gerrit.wikimedia.org/r/190734

Sumit mentioned this in rEMFR3409bd2b9251: TOC: horizontal scrolling added for long words.Feb 25 2015, 5:50 PM
Jdforrester-WMF removed a project: Patch-For-Review.Mar 3 2015, 5:27 PM
Diffusion mentioned this in rMEXT8883e2599d8b: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 11 2015, 6:27 AM
• Phabricator_maintenance moved this task from 2015-16 Q4 to 2014-15 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:20 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits