Page MenuHomePhabricator
Create Task
Maniphest T89543

ve.init.mw.ViewPageTarget#transformPage triggers recalculate style due to $.fn.animate
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Seen on osmium's [[Barack Obama]]:

Screen_Shot_2015-02-12_at_16.19.44.png (351×593 px, 40 KB)

It should be replaced with native CSS transition.

Previously discussed @ T87160#1038218.

Details

SubjectRepoBranchLines +/-
mw.ViewPageTarget: Use CSS for toolbar transitionmediawiki/extensions/VisualEditormaster+57 -23
mw.ViewPageTarget: Remove JS animations from transformPage()mediawiki/extensions/VisualEditormaster+5 -19
mw.ViewPageTarget: Use CSS for toolbar transitionmediawiki/extensions/VisualEditormaster+41 -27
Customize query in gerrit

Related Objects

Event Timeline

ori created this task.Feb 14 2015, 8:46 AM
ori raised the priority of this task from to Needs Triage.
ori updated the task description. (Show Details)
ori added a project: VisualEditor-Performance.
ori added subscribers: ori, Catrope, Krinkle.
Restricted Application added a project: VisualEditor. · View Herald TranscriptFeb 14 2015, 8:46 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle claimed this task.Feb 14 2015, 9:56 AM
Krinkle set Security to None.
Jdforrester-WMF moved this task from To Triage to Bug Fixes on the VisualEditor board.Feb 17 2015, 12:12 AM
Jdforrester-WMF triaged this task as High priority.Feb 17 2015, 12:17 AM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Feb 18 2015, 3:33 PM
Jdforrester-WMF moved this task from Nominated to Accepted on the VisualEditor 2014/15 Q3 blockers board.Feb 18 2015, 4:22 PM
Jdforrester-WMF edited a custom field.Feb 18 2015, 5:28 PM
gerritbot subscribed.Feb 21 2015, 2:04 AM

Change 192047 had a related patch set uploaded (by Krinkle):
mw.ViewPageTarget: Remove JS animations from transformPage()

https://gerrit.wikimedia.org/r/192047

Patch-For-Review

Jdforrester-WMF moved this task from Bug Fixes to Blocked on the VisualEditor board.Feb 21 2015, 7:52 PM
gerritbot added a comment.Feb 23 2015, 8:46 AM

Change 192281 had a related patch set uploaded (by Krinkle):
mw.ViewPageTarget: Remove JS animations from transformPage()

https://gerrit.wikimedia.org/r/192281

Patch-For-Review

gerritbot added a comment.Feb 23 2015, 10:50 AM

Change 192292 had a related patch set uploaded (by Krinkle):
mw.ViewPageTarget: Use CSS for toolbar transition (alt)

https://gerrit.wikimedia.org/r/192292

Patch-For-Review

gerritbot added a comment.Feb 23 2015, 11:48 AM

Change 192292 abandoned by Krinkle:
mw.ViewPageTarget: Use CSS for toolbar transition

Reason:
This approach is quite elegant and minimalistic. It performs very well etc. However closing because the standards require position:fixed to be resolved relative to the rendering layer. This makes sense but is unfortunate.

This could be worked around if our toolbar wasn't part of the target. But that may be to revisit another day.

https://gerrit.wikimedia.org/r/192292

gerritbot added a comment.Feb 23 2015, 4:00 PM

Change 192281 merged by jenkins-bot:
mw.ViewPageTarget: Remove JS animations from transformPage()

https://gerrit.wikimedia.org/r/192281

Krinkle mentioned this in rEVED60e5ac0902e5: mw.ViewPageTarget: Remove JS animations from transformPage().Feb 23 2015, 4:00 PM
Jdforrester-WMF renamed this task from ve.init.mw.ViewPageTarget.transformPage triggers recalculate style due to $.fn.animate to ve.init.mw.ViewPageTarget#transformPage triggers recalculate style due to $.fn.animate.Feb 23 2015, 4:01 PM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF added a project: WMF-deploy-2015-02-25_(1.25wmf19).
Jdforrester-WMF moved this task from Accepted to Done on the VisualEditor 2014/15 Q3 blockers board.
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Feb 25 2015, 4:28 PM
gerritbot added a comment.Mar 2 2015, 11:39 AM

Change 192047 merged by jenkins-bot:
mw.ViewPageTarget: Use CSS for toolbar transition

https://gerrit.wikimedia.org/r/192047

Krinkle mentioned this in rEVED1c5c13fd16be: mw.ViewPageTarget: Use CSS for toolbar transition.Mar 2 2015, 11:39 AM
Krinkle moved this task from Backlog to Done on the VisualEditor-Performance board.Mar 19 2015, 10:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits