Page MenuHomePhabricator
Create Task
Maniphest T89572

In Thanks confirmation, "No" choice title text should not say "Send a thank you notification to this user"
Closed, ResolvedPublic
Actions

Description

It's okay to reuse the title text for 'Yes', but not for 'No'. Filed against core as well, since this is something jquery.confirmable could address in a simple, general way.

Details

SubjectRepoBranchLines +/-
Add custom title text for Yes and No Thank confirmationsmediawiki/extensions/Thanksmaster+11 -1
Improve title text in jquery.confirmablemediawiki/coremaster+16 -2
Customize query in gerrit

Related Objects

Event Timeline

• Mattflaschen-WMF created this task.Feb 15 2015, 12:15 AM
• Mattflaschen-WMF raised the priority of this task from to Needs Triage.
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF added projects: Thanks, MediaWiki-User-Interface.
• Mattflaschen-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2015, 12:15 AM
Legoktm set Security to None.Feb 15 2015, 12:21 AM
Legoktm added subscribers: wctaiwan, • matmarex.
• matmarex added a comment.Feb 15 2015, 12:57 AM

You can pass a buttonCallback function that would remove the title attribute from the "No" button. No changes to jquery.confirmable should be necessary.

• Mattflaschen-WMF added a comment.Feb 15 2015, 1:12 AM

Good point. It's not strictly required.

But just as there is general functionality for the Yes and No visible text, I think there should also be for the Yes and No title text.

This problem probably applies any time the main link uses a title attribute. Even when it doesn't, one may be useful (both for the main link and for Yes/No).

• Mattflaschen-WMF claimed this task.Feb 15 2015, 1:12 AM
• Mattflaschen-WMF updated the task description. (Show Details)
Aklapper triaged this task as Medium priority.Feb 15 2015, 9:47 PM
wctaiwan added a comment.EditedFeb 15 2015, 10:00 PM

I'm inclined to just make it so that jquery.confirmable doesn't include title text for the default yes / no buttons, since I can't think of a scenario in which it'd be desirable for the "no" action to inherit the title text. This shouldn't result in accessibility issues, given the button label is descriptive.

gerritbot added a project: Patch-For-Review.Feb 15 2015, 10:14 PM
gerritbot subscribed.

Change 190742 had a related patch set uploaded (by Wctaiwan):
Make jquery.confirmable not clone title text

https://gerrit.wikimedia.org/r/190742

Patch-For-Review

• Mattflaschen-WMF reassigned this task from • Mattflaschen-WMF to wctaiwan.EditedFeb 16 2015, 6:10 AM

In the future, you should check with the assignee before starting a bug that is already assigned.

Luckily, in this case, I did not start coding yet, though I did think about it.

wctaiwan added a comment.Feb 16 2015, 6:13 AM

Sorry, I just noticed I was CC'd, figured it was a quick one line patch and didn't see that it was assigned. I'll be more careful in the future.

• Mattflaschen-WMF added a comment.Feb 16 2015, 6:18 AM
In T89572#1040796, @wctaiwan wrote:

Sorry, I just noticed I was CC'd, figured it was a quick one line patch and didn't see that it was assigned. I'll be more careful in the future.

Thanks. No harm done.

• matmarex closed this task as Resolved.Feb 17 2015, 1:34 PM
• matmarex removed a project: Patch-For-Review.
• matmarex removed a subscriber: gerritbot.
gerritbot added a comment.Feb 17 2015, 1:39 PM

Change 190742 merged by jenkins-bot:
Improve title text in jquery.confirmable

https://gerrit.wikimedia.org/r/190742

wctaiwan mentioned this in rMW1147690eb18d: Improve title text in jquery.confirmable.Feb 17 2015, 1:40 PM
gerritbot added a project: Patch-For-Review.Feb 18 2015, 2:56 AM

Change 191242 had a related patch set uploaded (by Mattflaschen):
Add custom title text for Yes and No Thank confirmations

https://gerrit.wikimedia.org/r/191242

Patch-For-Review

• Mattflaschen-WMF added a subscriber: • DannyH.Feb 18 2015, 2:56 AM
• matmarex reopened this task as Open.Feb 18 2015, 12:30 PM
gerritbot added a comment.Feb 24 2015, 1:39 AM

Change 191242 merged by jenkins-bot:
Add custom title text for Yes and No Thank confirmations

https://gerrit.wikimedia.org/r/191242

• Mattflaschen-WMF mentioned this in rETHAb7cefb78ae98: Add custom title text for Yes and No Thank confirmations.Feb 24 2015, 1:39 AM
• Mattflaschen-WMF closed this task as Resolved.Feb 24 2015, 6:20 AM

@DannyH This is not part of the sprint, but you can test now on Beta Labs if you want (when it's back up, that is).

Diffusion mentioned this in rMEXTe9bca41d468d: Updated mediawiki/extensions Project: mediawiki/extensions/Thanks….Mar 11 2015, 6:27 AM
darthbhyrava mentioned this in T111735: Non-breaking spaces break page layout when confirming thanks in diff view.Mar 25 2016, 2:02 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits