Page MenuHomePhabricator
Create Task
Maniphest T89581

daemonize module not migrated from compat
Closed, ResolvedPublic
Actions

Description

bot.py imports daemonize , which was a custom module in compat.

In core, its use was migrated in December 2008, but the module wasnt included.
https://www.mediawiki.org/wiki/Special:Code/pywikipedia/6136

I incorrectly added package 'daemonize' https://pypi.python.org/pypi/daemonize as a dependency in September 2014 https://gerrit.wikimedia.org/r/#/c/159269/

Details

SubjectRepoBranchLines +/-
Use pywikibot.daemonize instead of external packagepywikibot/coremaster+6 -12
Import daemonize from compatpywikibot/coremaster+64 -0
Customize query in gerrit

Related Objects

Event Timeline

jayvdb created this task.Feb 15 2015, 1:40 AM
jayvdb claimed this task.
jayvdb raised the priority of this task from to Needs Triage.
jayvdb updated the task description. (Show Details)
jayvdb added a project: Pywikibot-compat-to-core.
jayvdb subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2015, 1:40 AM
gerritbot added a project: Patch-For-Review.Feb 15 2015, 2:22 AM
gerritbot subscribed.

Change 190696 had a related patch set uploaded (by John Vandenberg):
Import daemonize from compat

https://gerrit.wikimedia.org/r/190696

Patch-For-Review

gerritbot added a comment.Feb 15 2015, 2:28 AM

Change 190697 had a related patch set uploaded (by John Vandenberg):
Use pywikibot.daemonize instead of external package

https://gerrit.wikimedia.org/r/190697

Patch-For-Review

jayvdb mentioned this in T86015: Install all pywikibot python optional dependencies on tool labs.Feb 15 2015, 3:06 AM
Ricordisamoa subscribed.Feb 17 2015, 9:31 AM
jayvdb triaged this task as High priority.Apr 9 2015, 6:09 AM

setup.py and requirements.txt currently install an unused package. As a result, fixing this is a way to speed up 3 travis jobs per builds, even if it is only a marginal improvement.

jayvdb added a project: Pywikibot.Apr 9 2015, 6:09 AM
Restricted Application added a subscriber: Unknown Object (MLST). · View Herald TranscriptApr 9 2015, 6:09 AM
jayvdb moved this task from Backlog to Next main release on the Pywikibot board.Apr 9 2015, 6:09 AM
gerritbot added a comment.May 14 2015, 4:35 PM

Change 190696 merged by jenkins-bot:
Import daemonize from compat

https://gerrit.wikimedia.org/r/190696

jayvdb mentioned this in rPWBC31bb968d37d5: Import daemonize from compat.May 14 2015, 4:35 PM
gerritbot added a comment.May 14 2015, 4:53 PM

Change 190697 merged by jenkins-bot:
Use pywikibot.daemonize instead of external package

https://gerrit.wikimedia.org/r/190697

Ladsgroup mentioned this in rPWBC6a9a27b271bc: Use pywikibot.daemonize instead of external package.May 14 2015, 4:54 PM
Ladsgroup closed this task as Resolved.May 14 2015, 8:06 PM
Ladsgroup removed a project: Patch-For-Review.
Ladsgroup set Security to None.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits